[virt-tools-list] [PATCH virt-viewer v2] Add missing G_MODULE_EXPORT to signal handler

[Marc-André Lureau]

On Fri, Jan 18, 2019 at 11:53 PM Eduardo Lima (Etrunko)
<etrunko at redhat.com> wrote:
>
> Fixes the Windows case where the dialog fails to show with the following
> message:
>
> warning: "Could not find signal handler 'virt_viewer_window_menu_change_cd_activate'"
>
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

ack

> ---
>
> in v2:
>  - Apply similar fix to handlers in remote-viewer-iso-list-dialog.c
>
> ---
>  src/remote-viewer-iso-list-dialog.c | 4 ++--
>  src/virt-viewer-window.c            | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/remote-viewer-iso-list-dialog.c b/src/remote-viewer-iso-list-dialog.c
> index 745768a..3505211 100644
> --- a/src/remote-viewer-iso-list-dialog.c
> +++ b/src/remote-viewer-iso-list-dialog.c
> @@ -216,7 +216,7 @@ remote_viewer_iso_list_dialog_response(GtkDialog *dialog,
>      remote_viewer_iso_list_dialog_refresh_iso_list(self);
>  }
>
> -void
> +G_MODULE_EXPORT void
>  remote_viewer_iso_list_dialog_toggled(GtkCellRendererToggle *cell_renderer G_GNUC_UNUSED,
>                                        gchar *path,
>                                        gpointer user_data)
> @@ -247,7 +247,7 @@ remote_viewer_iso_list_dialog_toggled(GtkCellRendererToggle *cell_renderer G_GNU
>      g_free(name);
>  }
>
> -void
> +G_MODULE_EXPORT void
>  remote_viewer_iso_list_dialog_row_activated(GtkTreeView *view G_GNUC_UNUSED,
>                                              GtkTreePath *path,
>                                              GtkTreeViewColumn *col G_GNUC_UNUSED,
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index 9b8e409..a7b2deb 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -1211,7 +1211,7 @@ iso_dialog_response(GtkDialog *dialog,
>  }
>  #endif
>
> -void
> +G_MODULE_EXPORT void
>  virt_viewer_window_menu_change_cd_activate(GtkWidget *menu G_GNUC_UNUSED,
>                                             VirtViewerWindow *self G_GNUC_UNUSED)
>  {
> --
> 2.20.1
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list