[virt-tools-list] [virt-bootstrap PATCHv2 2/3] Use absolute destination path

Radostin Stoyanov rstoyanov1 at gmail.com
Thu Jul 4 20:59:11 UTC 2019


In order to avoid issues, for example, when virt-sandbox might not
convert relative to absolute path, make sure that we always use
absolute destination path.

Reviewed-by: Cole Robinson <crobinso at redhat.com>
Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
---
 src/virtBootstrap/virt_bootstrap.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/virtBootstrap/virt_bootstrap.py b/src/virtBootstrap/virt_bootstrap.py
index 4bfa95d..cfe7aab 100755
--- a/src/virtBootstrap/virt_bootstrap.py
+++ b/src/virtBootstrap/virt_bootstrap.py
@@ -121,10 +121,11 @@ def bootstrap(uri, dest,
 
     uri = urlparse(uri)
     source = get_source(uri.scheme or 'file')
+    dest = os.path.abspath(dest)
 
     if not os.path.exists(dest):
         os.makedirs(dest)
-    elif os.path.abspath(dest) == "/":  # Don't overwrite root
+    elif dest == "/":  # Don't overwrite root
         logger.error("Unpack to root directory is not allowed")
         sys.exit(1)
     elif not os.path.isdir(dest):  # Show error if not directory
-- 
2.21.0




More information about the virt-tools-list mailing list