[virt-tools-list] [virt-manager PATCH 0/5] unattended: Use generate_*_for_media() APIs

[Cole Robinson]

On 7/12/19 9:02 AM, Fabiano Fidêncio wrote:
> This patch series include:
> - A patch simplifying _generate_debug();
>   - I'm taking Cole's suggestion when he reviewed the patch that ended
>     up merged and just saving & resetting the original user & admin
>     passwords after generating the debug output;
> 
> - A series using generate_*_for_media() APIs from libosinfo:
>   - Those 4 patches use libosinfo specific APIs for media, which would
>     take the media used in consideration when generating the install
>     script and its kernel command-line. Taking advantage of this helps
>     us as some logic is already done on osinfo-db side in order to
>     properly figure out what are the bits needed on the installer side
>     for netinst medias. Unfortunately, we still need to keep the
>     is_netinst() method as it's needed in order to decide when we
>     virt-install should set the network-install resources instead of
>     just using the normal resources.
> 
> Fabiano Fidêncio (5):
>   unattended: Simplify _generate_debug()
>   osdict: Add get_osinfo_media() to _OsMedia class
>   unattended: Pass OsinfoMedia to OSInstallScript
>   unattended: Use generate_*_for_media when possible
>   unattended: Always set "media" as install-source for ISOs
> 
>  ...virt-install-osinfo-netinst-unattended.xml |  2 +-
>  virtinst/install/unattended.py                | 43 ++++++++++---------
>  virtinst/osdict.py                            |  3 ++
>  3 files changed, 26 insertions(+), 22 deletions(-)
> 

Reviewed-by: Cole Robinson <crobinso at redhat.com>

Patch 1 had some busted syntax, but after fixing that everything worked
nicely. Pushed now

Thanks,
Cole