[virt-tools-list] [virt-bootstrap PATCH 1/3] safe-untar: Inherit SElinux context

Cole Robinson crobinso at redhat.com
Tue Jun 4 15:04:48 UTC 2019


On 6/4/19 6:26 AM, Radostin Stoyanov wrote:
> Lets virt-sandbox inherit the SElinux context of virt-bootstrap.
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
> ---
>  src/virtBootstrap/utils.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/virtBootstrap/utils.py b/src/virtBootstrap/utils.py
> index cd03a93..b0f695d 100644
> --- a/src/virtBootstrap/utils.py
> +++ b/src/virtBootstrap/utils.py
> @@ -269,6 +269,7 @@ def safe_untar(src, dest):
>      Extract tarball within LXC container for safety.
>      """
>      virt_sandbox = ['virt-sandbox',
> +                    '-s', 'inherit',
>                      '-c', LIBVIRT_CONN,
>                      '--name=bootstrap_%s' % os.getpid(),
>                      '-m', 'host-bind:/mnt=' + dest]  # Bind destination folder
> 

Reviewed-by: Cole Robinson <crobinso at redhat.com>

Side note: I prefer long option variants in cases like this, makes the
command invocation more self documenting for those who don't know what
the short options are.

Thanks,
Cole




More information about the virt-tools-list mailing list