[virt-tools-list] [virt-bootstrap PATCH 2/3] Use absolute destination path

[Cole Robinson]

On 6/4/19 6:26 AM, Radostin Stoyanov wrote:
> In order to avoid issues, for example, when virt-sandbox might not
> convert relative to absolute path, make sure that we always use
> absolute destination path.
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
> ---
>  src/virtBootstrap/virt_bootstrap.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/virtBootstrap/virt_bootstrap.py b/src/virtBootstrap/virt_bootstrap.py
> index 4bfa95d..cfe7aab 100755
> --- a/src/virtBootstrap/virt_bootstrap.py
> +++ b/src/virtBootstrap/virt_bootstrap.py
> @@ -121,10 +121,11 @@ def bootstrap(uri, dest,
>  
>      uri = urlparse(uri)
>      source = get_source(uri.scheme or 'file')
> +    dest = os.path.abspath(dest)
>  
>      if not os.path.exists(dest):
>          os.makedirs(dest)
> -    elif os.path.abspath(dest) == "/":  # Don't overwrite root
> +    elif dest == "/":  # Don't overwrite root
>          logger.error("Unpack to root directory is not allowed")
>          sys.exit(1)
>      elif not os.path.isdir(dest):  # Show error if not directory
> 

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole