[virt-tools-list] [virt-manager PATCH 00/12] A few fixes/improvements for Windows(es) unattended install

Fabiano Fidêncio fidencio at redhat.com
Thu Jun 6 14:11:31 UTC 2019


This patch series tries to cover a few issues that we had with regards to
unattended installations (some of them, not only Windows related).

The first 2 patches ensure that for every new installation, a
(or similar) ~/.cache/virt-manager/$pid/unattended folder is created. As
the path is associated to the process id, we avoid a possible clash of
files being written (& re-written) in case two parallel installations are
fired.

The patch is just a simple cleanup, taking advantage of the first 2
patches.

The following 3 patchs are related to cleaning up the files used.

The 7th patch switches to using cdrom as the preferred installation
method for Windows(es). This basic limits installations for Windows
Vista+ and depends on a few patches that are in libosinfo ML:
https://www.redhat.com/archives/libosinfo/2019-June/msg00010.html

All the other patches are related to pre/post install drivers for the
Windows(es) VMs.

There are a few things that are bothering me quite a lot and I'll need
some help to investigate them:
- Unattended installation of Windows 7 does *not* work with the drivers
  pointed by osinfo-db. It does work as expected when using up-to-date
  drivers, tho.
- There's no way to remove the created iso & cdrom device as part of the
  installation.
- Shall we return pre-installable devices when calling _get_all_devices()
  in all cases or just when dealing with unattended installations? Most
  likely the latter ... but how to do that only when dealing with
  unattended installs?
- Everytime the unattended cdrom is added, a new pool is created. It's
  already the current behaviour with the floppy.

Fabiano Fidêncio (12):
  util: Add {make,get}_unattended_cache_dir()
  unattended: Use make_unattended_cache_dir()
  floppyinject: Simplify perform_floppy_injections()
  installer: Cleanup process id & unattended cache dirs
  installer: Log when cleaning up the unattended files
  installertreemedia: Cleanup process id & unattended cache dirs
  unattended: Prefer cdrom instead of floppy for Windows
  osdict: Add methods to deal with pre/post install drivers
  osdict: Also return pre-installable devices as part of
    _get_all_devices()
  unattended: Add method to download drivers
  unattended: Deal with multiple install scripts
  installer: pre/post install drivers

 virt-manager.spec.in           |  5 ---
 virtinst/cdrominject.py        | 26 ++++++++++++
 virtinst/floppyinject.py       | 36 -----------------
 virtinst/installer.py          | 74 ++++++++++++++++++++++++----------
 virtinst/installertreemedia.py | 27 +++++++++----
 virtinst/osdict.py             | 68 +++++++++++++++++++++++++++++--
 virtinst/unattended.py         | 51 +++++++++++++++--------
 virtinst/util.py               | 13 ++++++
 8 files changed, 210 insertions(+), 90 deletions(-)
 create mode 100644 virtinst/cdrominject.py
 delete mode 100644 virtinst/floppyinject.py

-- 
2.21.0




More information about the virt-tools-list mailing list