[virt-tools-list] [virt-manager PATCH 4/6] devices: disk: Use virtio-scsi for CDROMs where supported

Cole Robinson crobinso at redhat.com
Wed Mar 6 19:37:17 UTC 2019


On 3/4/19 11:11 AM, Andrea Bolognani wrote:
> We already use virtio-blk for regular disks whenever possible,
> and there's no good reason not to do the same with virtio-scsi
> when dealing with CDROMs instead of artificially limiting its
> use to s390x and ppc64/pseries guests.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  .../compare/virt-install-kvm-session-defaults.xml           | 6 ++++--
>  tests/cli-test-xml/compare/virt-install-location-iso.xml    | 6 ++++--
>  virtinst/devices/disk.py                                    | 4 +---
>  3 files changed, 9 insertions(+), 7 deletions(-)
> 

This one makes me a bit uncomfortable because we are changing a long
held x86 default... but whatever, I'm willing to give it a spin and see
if it causes problems.

Everything else looks good, pushed now

Thanks,
Cole




More information about the virt-tools-list mailing list