[virt-tools-list] [PATCH] virt-install: Do not warn about consoles on s390x

Christian Borntraeger borntraeger at de.ibm.com
Thu Mar 14 08:50:11 UTC 2019


s390x guests usually detect the sclp or virtio console. The current
warning might actually break setups. Let us disable the warning.

Reported-by: Andre Wild <wild1 at linux.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger at de.ibm.com>
---
 virt-install | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/virt-install b/virt-install
index d7af107b..291b4a0a 100755
--- a/virt-install
+++ b/virt-install
@@ -402,9 +402,9 @@ def _show_nographics_warnings(options, guest, installer):
         console_type = serial_arm_arg
     if guest.devices.console[0].target_type in ["virtio", "xen"]:
         console_type = hvc_arg
-    if guest.os.is_ppc64() or guest.os.is_arm_machvirt():
-        # Later arm/ppc kernels figure out console= automatically, so don't
-        # warn about it.
+    if guest.os.is_ppc64() or guest.os.is_arm_machvirt() or guest.os.is_s390x:
+        # Later arm/ppc/s390x kernels figure out console= automatically, so
+        # don't warn about it.
         return
 
     for args in (options.extra_args or []):
-- 
2.19.1




More information about the virt-tools-list mailing list