[virt-tools-list] [virt-manager PATCH 0/8] cpu related bug fixes and improvements

[Pavel Hrdina]

On Fri, Mar 15, 2019 at 02:49:22PM -0400, Cole Robinson wrote:
> On 3/15/19 12:41 PM, Pavel Hrdina wrote:
> > Pavel Hrdina (8):
> >    domcapabilities: fix detection if host-model is safe to use
> >    tests: xmlparse: use set_special_mode function
> >    tests: capabilities: remove testCPUAPI
> >    domcapabilities: fix CPUModel usable attribute
> >    domcapabilities: get list of CPU models from domcapabilities
> >    domcapabilities: introduce get_cpu_security_features
> >    domain: cpu: introduce set_model function
> >    domain: cpu: automatically add CPU security features for "custom" mode
> > 
> >   tests/capabilities.py                         | 32 ----------
> >   .../compare/virt-install-qemu-plain.xml       |  2 +
> >   .../virt-install-singleton-config-2.xml       |  4 ++
> >   tests/xmlparse.py                             | 16 +++--
> >   virtManager/connection.py                     |  3 -
> >   virtManager/details.py                        |  2 +-
> >   virtManager/domain.py                         |  2 +-
> >   virtinst/capabilities.py                      | 25 --------
> >   virtinst/cli.py                               |  2 +-
> >   virtinst/domain/cpu.py                        | 42 ++++++++-----
> >   virtinst/domcapabilities.py                   | 60 ++++++++++++++++++-
> >   virtinst/support.py                           |  6 +-
> >   12 files changed, 106 insertions(+), 90 deletions(-)
> > 
> 
> With the bits I mentioned in patch #6:
> 
> Reviewed-by: Cole Robinson <crobinso at redhat.com>

Thanks, I'll fix the issues.

> Also I think it would be good to add a follow up patch/patches to privatize
> cpu.model and cpu.mode if they shouldn't be set directly

Right, good idea, I'll fix that as a follow up.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20190318/6be3f9a0/attachment.sig>