[virt-tools-list] [virt-manager PATCH 2/6] tests: cli: Add simple headless guests

[Pavel Hrdina]

On Wed, Mar 20, 2019 at 04:52:31PM +0100, Andrea Bolognani wrote:
> These cover the use case "I want to get an existing guest
> image running in the cloud, and I don't need graphics".
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  .../compare/virt-install-aarch64-headless.xml | 41 +++++++++++++++
>  .../compare/virt-install-ppc64-headless.xml   | 39 ++++++++++++++
>  .../compare/virt-install-s390x-headless.xml   | 36 +++++++++++++
>  .../compare/virt-install-x86_64-headless.xml  | 52 +++++++++++++++++++
>  tests/clitest.py                              |  8 +++
>  5 files changed, 176 insertions(+)
>  create mode 100644 tests/cli-test-xml/compare/virt-install-aarch64-headless.xml
>  create mode 100644 tests/cli-test-xml/compare/virt-install-ppc64-headless.xml
>  create mode 100644 tests/cli-test-xml/compare/virt-install-s390x-headless.xml
>  create mode 100644 tests/cli-test-xml/compare/virt-install-x86_64-headless.xml

[...]

> diff --git a/tests/clitest.py b/tests/clitest.py
> index 119d85b7..b84e7fa9 100644
> --- a/tests/clitest.py
> +++ b/tests/clitest.py
> @@ -804,6 +804,14 @@ c.add_compare("--connect %(URI-KVM-AARCH64)s --disk %(EXISTIMG1)s --import --os-
>  c.add_compare("--connect %(URI-KVM-AARCH64)s --disk size=1 --os-variant fedora22 --features gic_version=host --network network=default,address.type=pci --controller type=scsi,model=virtio-scsi,address.type=pci", "aarch64-kvm-gic")
>  
>  
> +# Simple headless guests for various architectures
> +c = vinst.add_category("kvm-headless", "--os-variant fedora29 --import --disk %(EXISTIMG1)s --network default --rng /dev/urandom --graphics none")

Do you have any specific reason to use
'--disk %(EXISTIMG1)s --network default --rng /dev/urandom' ?

We can easily use '--disk none --network none' instead to make the XML
as minimal as possible.  It will save us some changes in the future.

I can change it before pushing.

Pavel

> +c.add_compare("--connect %(URI-KVM-AARCH64)s --arch aarch64", "aarch64-headless")
> +c.add_compare("--connect %(URI-KVM-PPC64LE)s --arch ppc64le", "ppc64-headless")
> +c.add_compare("--connect %(URI-KVM-S390X)s --arch s390x", "s390x-headless")
> +c.add_compare("--connect %(URI-KVM)s --arch x86_64", "x86_64-headless")
> +
> +
>  
>  ######################
>  # LXC specific tests #
> -- 
> 2.20.1
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20190321/b47d33ae/attachment.sig>