[virt-manager PATCH] details: fix detection of firmware auto-selection

Pavel Hrdina phrdina at redhat.com
Thu Aug 13 14:44:32 UTC 2020


Commit <15a9502b7b7a263c4d66ff2b3f31c209f58fe0b4> fixed firmware
detection but incorrectly. It will always show only "UEFI" even if
the firmware auto-selection is not used because the function is_uefi()
checks both the old style and the new auto-selection.

We have to check only for the auto-selection option.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

Pushed

 virtManager/details/details.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtManager/details/details.py b/virtManager/details/details.py
index 89f3e0be..a6ccdc85 100644
--- a/virtManager/details/details.py
+++ b/virtManager/details/details.py
@@ -1886,7 +1886,7 @@ class vmmDetails(vmmGObjectUI):
 
         # Firmware
         domcaps = self.vm.get_domain_capabilities()
-        if self.vm.get_xmlobj().is_uefi():
+        if self.vm.get_xmlobj().os.firmware == "efi":
             firmware = 'UEFI'
         else:
             firmware = domcaps.label_for_firmware_path(
-- 
2.26.2




More information about the virt-tools-list mailing list