[virt-manager PATCH 11/21] i18n: use "Generic OS" as label for generic

Pino Toscano ptoscano at redhat.com
Mon Jul 13 08:25:49 UTC 2020


Change the label for a generic OS to "Generic OS", and making it
translatable.

Signed-off-by: Pino Toscano <ptoscano at redhat.com>
---
 tests/uitests/test_newvm.py | 2 +-
 ui/oslist.ui                | 2 +-
 virtinst/osdict.py          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/uitests/test_newvm.py b/tests/uitests/test_newvm.py
index 92230c13..632751a7 100644
--- a/tests/uitests/test_newvm.py
+++ b/tests/uitests/test_newvm.py
@@ -102,7 +102,7 @@ class NewVM(uiutils.UITestCase):
         newvm.find("oslist-popover")
         osentry.click()
         self.pressKey("Enter")
-        uiutils.check_in_loop(lambda: osentry.text == "Generic default")
+        uiutils.check_in_loop(lambda: osentry.text == "Generic OS")
 
         # Verify back+forward still keeps Generic selected
         self.sleep(.5)
diff --git a/ui/oslist.ui b/ui/oslist.ui
index eb082d4e..546c0a2a 100644
--- a/ui/oslist.ui
+++ b/ui/oslist.ui
@@ -54,7 +54,7 @@
                 <property name="halign">start</property>
                 <property name="label" translatable="yes">Can't find the operating system you are looking for?
 Try selecting the next most recent version displayed,
-or use the "Generic" entry.</property>
+or use the "Generic OS" entry.</property>
               </object>
               <packing>
                 <property name="expand">True</property>
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index 97fb46e6..95398f5d 100644
--- a/virtinst/osdict.py
+++ b/virtinst/osdict.py
@@ -377,7 +377,7 @@ class _OsVariant(object):
         self.name = self._short_ids[0]
 
         self.full_id = self._os and self._os.get_id() or None
-        self.label = self._os and self._os.get_name() or "Generic default"
+        self.label = self._os and self._os.get_name() or _("Generic OS")
         self.codename = self._os and self._os.get_codename() or ""
         self.distro = self._os and self._os.get_distro() or ""
         self.version = self._os and self._os.get_version() or None
-- 
2.26.2




More information about the virt-tools-list mailing list