[virt-manager PATCH 00/16] Various i18n fixes, part #2

Cole Robinson crobinso at redhat.com
Tue Jul 14 15:25:42 UTC 2020


On 7/14/20 3:41 AM, Pino Toscano wrote:
> This patch series remove some more of the i18n issues, mostly
> untranslatable strings, string puzzles, and plural forms.
> 
> Also a couple of bugs related to i18n are fixed.
> 

Thanks! I pushed with this squashed into the details.py controller
patch, so that index=0 is still listed in the UI

diff --git a/virtManager/details/details.py b/virtManager/details/details.py
index 4a00dd6d..89f3e0be 100644
--- a/virtManager/details/details.py
+++ b/virtManager/details/details.py
@@ -254,7 +254,7 @@ def _label_for_device(dev):
         return _("Filesystem %(path)s") % {"path": dev.target[:8]}
     if devtype == "controller":
         idx = dev.index
-        if idx:
+        if idx is not None:
             return _("Controller %(controller)s %(index)s") % {
                 "controller": vmmAddHardware.controller_pretty_desc(dev),
                 "index": idx,


- Cole




More information about the virt-tools-list mailing list