[PATCH virt-install v1 3/3] virtxml: prevent defining same hostdev again

Cole Robinson crobinso at redhat.com
Tue May 18 22:49:25 UTC 2021


On 4/14/21 11:18 AM, Shalini Chellathurai Saroja wrote:
> Currently, it is possible to add same device multiple times, when the
> guest domain is in shut-off state. This patch prevents this unexpected
> behavior for all hostdev devices, including mdev devices.
> 

If this is an invalid config, these types of validation checks should
live in libvirt so all clients benefit from them, and libvirt is the one
source of truth for what's supported or not.

We make some exceptions in virt-install/virt-xml to validate common
configuration errors but I don't think this is one of them.

Thanks,
Cole




More information about the virt-tools-list mailing list