[virt-manager][PATCH] Update domain title/description on corresponding event

Cole Robinson crobinso at redhat.com
Wed Feb 9 16:05:45 UTC 2022


On 2/8/22 9:12 AM, Michal Privoznik wrote:
> If a domain is edited outside of virt-manager (e.g. via virsh
> edit) then this is reflected in the GUI (in the domain HW details
> tab). However, if domain title or description is updated outside
> of virt-manager (virsh desc) then this change is not reflected.
> This is simply because the corresponding event emitted by libvirt
> is not listened to.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  virtManager/connection.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/virtManager/connection.py b/virtManager/connection.py
> index 68a37ea6..6585fef6 100644
> --- a/virtManager/connection.py
> +++ b/virtManager/connection.py
> @@ -765,6 +765,7 @@ class vmmConnection(vmmGObject):
>          _add_domain_xml_event("VIR_DOMAIN_EVENT_ID_DEVICE_ADDED", 19)
>          _add_domain_xml_event("VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE", 18,
>                                self._domain_agent_lifecycle_event)
> +        _add_domain_xml_event("VIR_DOMAIN_EVENT_ID_METADATA_CHANGE", 23)
>  
>          try:
>              _check_events_disabled()

Thanks, pushed now

- Cole




More information about the virt-tools-list mailing list