[virt-manager PATCH] Fix checking for graphics spice for Xen

[Cole Robinson]

On 2/9/22 9:50 AM, Charles Arnold wrote:
> Advertising graphics support doesn't necessarily mean spice support.
> self.devices.graphics.supported seems to not be spice specific
> but rather more generic in indicating whether graphics are supported.
> For Xen, spice is not supported so fallback to the old logic.
> 
> Signed-off-by: Charles Arnold <carnold at suse.com>
> 
> diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py
> index 67bceaa3..ad6e3363 100644
> --- a/virtinst/domcapabilities.py
> +++ b/virtinst/domcapabilities.py
> @@ -382,7 +382,7 @@ class DomainCapabilities(XMLBuilder):
>          return len(models) > 0 and bool("emulator" in backends)
> 
>      def supports_graphics_spice(self):
> -        if not self.devices.graphics.supported:
> +        if not self.devices.graphics.supported or self.conn.is_xen():
>              # domcaps is too old, or the driver doesn't advertise graphics
>              # support. Use our pre-existing logic
>              if not self.conn.is_qemu() and not self.conn.is_test():
> 
> 

Hmm but does that mean domcapabilities for xen is reporting that spice
is available? If that's the case, seems like a domcapabilities bug in
libvirt xen driver. Or am I missing something?

Thanks,
Cole