[Virtio-fs] [PATCH][RFC] viriofsd: do not fall back to buffer io when cache=auto
piaojun
piaojun at huawei.com
Wed Aug 14 09:46:42 UTC 2019
Direct io flags will be tured off even if cache=auto, which seems a
little bit strange. It's better to keep the open flags set by user. If
I missed the discussion about this issue, please let me know, thanks.
Signed-off-by: Jun Piao <piaojun at huawei.com>
---
contrib/virtiofsd/passthrough_ll.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/contrib/virtiofsd/passthrough_ll.c b/contrib/virtiofsd/passthrough_ll.c
index 321bbb2..a080f0d 100644
--- a/contrib/virtiofsd/passthrough_ll.c
+++ b/contrib/virtiofsd/passthrough_ll.c
@@ -1687,6 +1687,8 @@ static void lo_create(fuse_req_t req, fuse_ino_t parent, const char *name,
fi->direct_io = 1;
else if (lo->cache == CACHE_ALWAYS)
fi->keep_cache = 1;
+ else
+ fi->direct_io = !!(fi->flags & O_DIRECT);
out:
lo_inode_put(lo, &parent_inode);
@@ -1899,6 +1901,8 @@ static void lo_open(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi)
fi->direct_io = 1;
else if (lo->cache == CACHE_ALWAYS)
fi->keep_cache = 1;
+ else
+ fi->direct_io = !!(fi->flags & O_DIRECT);
fuse_reply_open(req, fi);
}
--
More information about the Virtio-fs
mailing list