[Virtio-fs] [PATCH v2] virtiofsd: fix compile error if 'F_OFD_GETLK' not defined
Dr. David Alan Gilbert
dgilbert at redhat.com
Fri Aug 2 10:53:52 UTC 2019
* piaojun (piaojun at huawei.com) wrote:
> Use F_GETLK for fcntl when F_OFD_GETLK not defined, such as kernel 3.10.
>
> Signed-off-by: Jun Piao <piaojun at huawei.com>
> ---
> v2:
> - Use F_OFD_SETLK to replace F_OFD_GETLK in #ifdef.
>
> ---
> contrib/virtiofsd/passthrough_ll.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/contrib/virtiofsd/passthrough_ll.c b/contrib/virtiofsd/passthrough_ll.c
> index a81c01d..c69f2f3 100644
> --- a/contrib/virtiofsd/passthrough_ll.c
> +++ b/contrib/virtiofsd/passthrough_ll.c
> @@ -1780,7 +1780,11 @@ static void lo_getlk(fuse_req_t req, fuse_ino_t ino,
> goto out;
> }
>
> +#ifdef F_OFD_GETLK
> ret = fcntl(plock->fd, F_OFD_GETLK, lock);
> +#else
> + ret = fcntl(plock->fd, F_GETLK, lock);
> +#endif
> if (ret == -1)
> saverr = errno;
>
> @@ -1831,7 +1835,11 @@ static void lo_setlk(fuse_req_t req, fuse_ino_t ino,
>
> /* TODO: Is it alright to modify flock? */
> lock->l_pid = 0;
> +#ifdef F_OFD_SETLK
> ret = fcntl(plock->fd, F_OFD_SETLK, lock);
> +#else
> + ret = fcntl(plock->fd, F_GETLK, lock);
^^^^^^^
Typo! You've got GETLK rather than SETLK.
But, a bigger question - does this actually work!
The manpage says:
'If a process closes any file descriptor referring to a file, then
all of the process's locks on that file are released, regardless of the
file descriptor(s) on which the locks were obtained.'
the fd we're using here came from lookup_create_plock_ctx which did
a new openat to get this fd; so we've already got multiple fd's
referring to this file; and thus I worry we're going to close
one of them and lose all our locks on it.
Dave
> +#endif
> if (ret == -1) {
> saverr = errno;
> }
> --
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list