[Virtio-fs] [PATCH 0/3] virtio-fs: Add some tracepoints

[Stefan Hajnoczi]

On Mon, Aug 12, 2019 at 05:04:52PM -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma at jp.fujitsu.com>
> 
> This patch series introduce some tracepoints. It will be
> useful to debug the I/O request flow.
> 
> New trace events:
> 
>   - virtio_fs_request_dispatched
>   - virtio_fs_request_done
>   - virtio_fs_hiprio_request_dispatched
>   - virtio_fs_hiprio_request_done
> 
> Above trace events is added to the following functions as
> the tracepoints:
> 
>   - virtio_fs_enqueue_req
>   - virtio_fs_requests_done_work
>   - virtio_fs_hiprio_dispatch_work
>   - virtio_fs_hiprio_done_work
> 
> Example of the trace record:
> 
>   cat-1432        [006] .... 37.592694: virtio_fs_request_dispatched:
>       opcode FUSE_READ unique 0x1a nodeid 0x2 in.len 80 flags
>       ISREPLY|WAITING|SENT notify 1
>   kworker/4:1-103 [004] .... 37.592809: virtio_fs_request_done:
>       opcode FUSE_READ unique 0x1a nodeid 0x2 in.len 80 flags
>       ISREPLY|WAITING
> 
> Changelog:
>  From RFC:
>  - Change the string and the file name from virtiofs to virtio_fs.
>  - Separate the fuse macros to the other file to get useful for
>    generic fuse trace.
> 
> Masayoshi Mizuma (3):
>   fuse: add some macros for ftrace
>   virtio-fs: add ftrace events
>   virtio-fs: add tracepoints
> 
>  fs/fuse/virtio_fs.c                |  21 +++++
>  include/trace/events/fuse_common.h |  67 +++++++++++++++
>  include/trace/events/virtio_fs.h   | 131 +++++++++++++++++++++++++++++
>  3 files changed, 219 insertions(+)
>  create mode 100644 include/trace/events/fuse_common.h
>  create mode 100644 include/trace/events/virtio_fs.h
> 
> -- 
> 2.18.1
> 

Looks useful, thanks.  I'm concerned about use-after-frees, please see
my other email reply.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virtio-fs/attachments/20190820/ba772c82/attachment.sig>