[Virtio-fs] [PATCH] virtiofsd: fix double fuse_mbuf_iter_advance when do_removemapping
Catherine Ho
catherine.hecx at gmail.com
Thu Dec 5 09:01:26 UTC 2019
Commit 8e92b1fc98f7 ("DAX: virtiofsd: make FUSE_REMOVEMAPPING support
multiple entries") forgot to remove one fuse_mbuf_iter_advance in
do_removemapping.
Without this patch, virtiofsd will report:
[ID: 00000123] do_removemapping: invalid in, expected 1 * 16, has 60 - 60
[ID: 00000123] unique: 232, error: -22 (Invalid argument), outsize: 16
Fixes: 8e92b1fc98f7 ("DAX: virtiofsd: make FUSE_REMOVEMAPPING support multiple entries")
Cc: Peng Tao <tao.peng at linux.alibaba.com>
Signed-off-by: Catherine Ho <catherine.hecx at gmail.com>
---
contrib/virtiofsd/fuse_lowlevel.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/contrib/virtiofsd/fuse_lowlevel.c b/contrib/virtiofsd/fuse_lowlevel.c
index bde66c72c3..752e7d97b9 100644
--- a/contrib/virtiofsd/fuse_lowlevel.c
+++ b/contrib/virtiofsd/fuse_lowlevel.c
@@ -1894,14 +1894,6 @@ static void do_removemapping(fuse_req_t req, fuse_ino_t nodeid,
return;
}
- one = fuse_mbuf_iter_advance(iter, sizeof(*one));
- if (!one) {
- fuse_log(FUSE_LOG_ERR, "do_removemapping: invalid in, expected %d * %ld, has %ld - %ld\n",
- arg->count, sizeof(*one), iter->size, iter->pos);
- fuse_reply_err(req, EINVAL);
- return;
- }
-
if (req->se->op.removemapping)
req->se->op.removemapping(req, req->se, nodeid, arg->count, one);
else
--
2.17.1
More information about the Virtio-fs
mailing list