[Virtio-fs] [PATCH 1/5] virtiofsd: cleanup allocated resource in se
Dr. David Alan Gilbert
dgilbert at redhat.com
Thu Jun 6 09:04:30 UTC 2019
* Liu Bo (bo.liu at linux.alibaba.com) wrote:
> This cleans up unfreed resources in se on quiting, including
> se->virtio_dev, se->vu_socket_path, se->vu_socketfd.
>
> Signed-off-by: Liu Bo <bo.liu at linux.alibaba.com>
> ---
> contrib/virtiofsd/fuse_lowlevel.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/contrib/virtiofsd/fuse_lowlevel.c b/contrib/virtiofsd/fuse_lowlevel.c
> index 0fc2880..de700ad 100644
> --- a/contrib/virtiofsd/fuse_lowlevel.c
> +++ b/contrib/virtiofsd/fuse_lowlevel.c
> @@ -2557,6 +2557,12 @@ void fuse_session_destroy(struct fuse_session *se)
> free(se->cuse_data);
> if (se->fd != -1)
> close(se->fd);
> +
> + free(se->virtio_dev);
> + se->virtio_dev = NULL;
We don't touch virtio_dev or vu_socketfd anywhere else in fuse_lowlevel.c -
so we should probably do this cleanup in fuse_virtio.c, and then have
something like:
if (se->vu_socket_path) {
virtio_session_close(se);
free(se->vu_socket_path);
se->vu_socket_path = NULL;
}
> + free(se->vu_socket_path);
> + close(se->vu_socketfd);
> +
> free(se);
> }
>
> --
> 1.8.3.1
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs at redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list