[Virtio-fs] [PATCH] virtio_fs: Change module name to virtiofs.ko

Miklos Szeredi miklos at szeredi.hu
Mon Oct 14 08:25:51 UTC 2019


On Fri, Oct 11, 2019 at 8:18 PM Vivek Goyal <vgoyal at redhat.com> wrote:
>
> We have been calling it virtio_fs and even file name is virtio_fs.c. Module
> name is virtio_fs.ko but when registering file system user is supposed to
> specify filesystem type as "virtiofs".
>
> Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and
> got this warning on console.
>
>   ------------[ cut here ]------------
>   request_module fs-virtio_fs succeeded, but still no fs?
>   WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
>   Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
>   CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1
>
> So looks like kernel could find the module virtio_fs.ko but could not find
> filesystem type after that.
>
> It probably is better to rename module name to virtiofs.ko so that above
> warning goes away in case user ends up specifying wrong fs name.
>
> Reported-by: Masayoshi Mizuma <msys.mizuma at gmail.com>
> Suggested-by: Stefan Hajnoczi <stefanha at redhat.com>
> Signed-off-by: Vivek Goyal <vgoyal at redhat.com>

Thanks, applied.

Miklos




More information about the Virtio-fs mailing list