[Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

Xiao Yang yangx.jy at cn.fujitsu.com
Thu Jan 2 05:32:38 UTC 2020


On 2020/1/2 12:50, Eryu Guan wrote:
> On Thu, Jan 02, 2020 at 11:53:12AM +0800, Xiao Yang wrote:
>> >  lo_copy_file_range() passes -errno to fuse_reply_err() and then fuse_reply_err()
>> >  changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() catches
>> >  the wrong errno.(i.e. reports "fuse: bad error value: ...").
>> >  
>> >  Make fuse_send_reply_iov_nofree() accept the correct -errno by passing errno
>> >  directly in lo_copy_file_range().
>> >  
>> >  Signed-off-by: Xiao Yang<yangx.jy at cn.fujitsu.com>
> Looks good to me.
>
> Reviewed-by: Eryu Guan<eguan at linux.alibaba.com>
>
> I also went through the other fuse_reply_err() calls and they all pass
> positive error number to the second arg.
Hi Eryu,

Thanks for your review. :-)

Best Regards,
Xiao Yang
> Thanks,
> Eryu
>







More information about the Virtio-fs mailing list