[Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Fix wrong output format in lo_setxattr()
Dr. David Alan Gilbert
dgilbert at redhat.com
Tue Jan 21 10:02:35 UTC 2020
* Xiao Yang (yangx.jy at cn.fujitsu.com) wrote:
> Actual debug output:
> -------------------------------
> [2778114403742] [ID: 00000033] lo_setxattr(ino=93998909307364[2778114466291] [ID: 00000033] unique: 56, success, outsize: 16
> -------------------------------
> Correct debug output:
> -------------------------------
> 383 [2341816212531] [ID: 00000098] lo_setxattr(ino=3, name=user.test value=test size=4)
> -------------------------------
>
> Fixes: 63bc560920ad ("virtiofsd: print log only when priority is high enough)"
> Signed-off-by: Xiao Yang <yangx.jy at cn.fujitsu.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 57f58aef26..ff34e77a23 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2528,7 +2528,7 @@ static void lo_setxattr(fuse_req_t req, fuse_ino_t ino, const char *name,
> goto out;
> }
>
> - fuse_log(FUSE_LOG_DEBUG, "lo_setxattr(ino=%" PRIu64,
> + fuse_log(FUSE_LOG_DEBUG, "lo_setxattr(ino=%" PRIu64
> ", name=%s value=%s size=%zd)\n", ino, name, value, size);
>
> if (inode->is_symlink) {
Thank you for the fix! I think we need to mark fuse_log as being printf
format so hopefully it will spot more of these errors automatically.
Dave
> --
> 2.21.0
>
>
>
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs at redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list