[Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Fix wrong output format in lo_setxattr()

[Dr. David Alan Gilbert]

* Xiao Yang (yangx.jy at cn.fujitsu.com) wrote:
> On 2020/1/21 18:02, Dr. David Alan Gilbert wrote:
> > Thank you for the fix!  I think we need to mark fuse_log as being printf
> > format so hopefully it will spot more of these errors automatically.
> Hi Dave,
> 
> Do you perfer to write output to stdout rather than stderr? right?(e.g.
> replace vfprintf with vprintf?)

No, I think it's OK as is.

> BTW: Perhaps, log_func() needs to call g_free() after using
> g_strdup_printf().

No because the pointer is declared with g_autofree - it does the
free automatically.

Dave

> Thanks,
> Xiao Yang
> > Dave
> 
> 
> 
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK