[Virtio-fs] [PATCH] virtiofsd: Remove unused enum fuse_buf_copy_flags

Dr. David Alan Gilbert dgilbert at redhat.com
Thu Jan 23 10:19:29 UTC 2020


* Xiao Yang (yangx.jy at cn.fujitsu.com) wrote:
> On 2020/1/23 2:52, Dr. David Alan Gilbert wrote:
> > I'm confused as to which version this patch is against; all the worlds I
> > can see don't take 'req' into fuse_buf_copy.
> Hi Dave,
> 
> I just used the development branch:
> https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev
> 
> I saw that fuse_buf_copy() still has 'req' parameter on this branch.  Is it
> obsolete?
> https://gitlab.com/virtio-fs/qemu/blob/virtio-fs-dev/tools/virtiofsd/buffer.c#L270

OK, my mistake - the 'req' parameter is added late on, in the DAX
extensions; so I need to backport this cleanup before it.
I'll do that.

Dave

> Best Regards,
> Xiao Yang
> 
> 
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK




More information about the Virtio-fs mailing list