[Virtio-fs] [PATCH v2 1/2] virtiofsd: print more verbose information when bailing out
Dr. David Alan Gilbert
dgilbert at redhat.com
Fri Mar 20 18:59:39 UTC 2020
* Liu Bo (bo.liu at linux.alibaba.com) wrote:
> It'd be helpful to know what is the exact value of arg's offset, size
> and flags.
>
> Signed-off-by: Liu Bo <bo.liu at linux.alibaba.com>
Thanks,
> ---
> tools/virtiofsd/fuse_lowlevel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
> index a34a611..ca2056f 100644
> --- a/tools/virtiofsd/fuse_lowlevel.c
> +++ b/tools/virtiofsd/fuse_lowlevel.c
> @@ -1224,8 +1224,8 @@ static void do_write_buf(fuse_req_t req, fuse_ino_t nodeid,
> }
>
> if (fuse_buf_size(pbufv) != arg->size) {
> - fuse_log(FUSE_LOG_ERR,
> - "fuse: do_write_buf: buffer size doesn't match arg->size\n");
> + fuse_log(FUSE_LOG_ERR, "fuse: do_write_buf: buffer size %lu doesn't match arg->size %u offset %lu flags %u\n",
> + fuse_buf_size(pbufv), arg->size, arg->offset, arg->write_flags);
Please use %zu for size_t's (i.e. fuse_buf_size) and %llu with a cast to
(unsigned long long) for uint64_t's; also it's gone over the maximum
line limit of 80 characters for qemu.
Dave
> fuse_reply_err(req, EIO);
> return;
> }
> --
> 1.8.3.1
>
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs at redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list