[Virtio-fs] [PATCH 3/3] virtiofsd: check whether strdup lo.source return NULL in main func
Dr. David Alan Gilbert
dgilbert at redhat.com
Wed Nov 11 19:55:00 UTC 2020
* Haotian Li (lihaotian9 at huawei.com) wrote:
> In main func, strdup lo.source may fail. So check whether strdup
> lo.source return NULL before using it.
>
> Signed-off-by: Haotian Li <lihaotian9 at huawei.com>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26 at huawei.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 3e9bbc7a04..0c11134fb5 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -3525,6 +3525,10 @@ int main(int argc, char *argv[])
> }
> } else {
> lo.source = strdup("/");
> + if (!lo.source) {
> + fuse_log(FUSE_LOG_ERR, "failed to strdup source\n");
> + goto err_out1;
> + }
> }
>
(It's interesting we use exit's in some places, goto's in others)
Reviewed-by: Dr. David Alan Gilbert <dgilbert at redhat.com>
> if (lo.xattrmap) {
> --
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs at redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list