[Virtio-fs] [PATCH] vhost-user-fs: add the "bootindex" property

Cornelia Huck cohuck at redhat.com
Mon Jan 11 16:22:08 UTC 2021


On Mon,  4 Jan 2021 14:24:01 +0100
Laszlo Ersek <lersek at redhat.com> wrote:

> virtio-fs qualifies as a bootable device minimally under OVMF, but
> currently the necessary "bootindex" property is missing (fw_cfg kernel
> boot notwithstanding).
> 
> Add the property. For completeness, add it to the CCW device as well;
> other virtio-ccw devices seem to have "bootindex" properties too.
> 
> Example OpenFirmware device path for the "vhost-user-fs-pci" device in the
> "bootorder" fw_cfg file:
> 
>   /pci at i0cf8/pci-bridge at 1,6/pci1af4,105a at 0/filesystem at 0
> 
> Cc: "Dr. David Alan Gilbert" <dgilbert at redhat.com>
> Cc: "Michael S. Tsirkin" <mst at redhat.com>
> Cc: Christian Borntraeger <borntraeger at de.ibm.com>
> Cc: Cornelia Huck <cohuck at redhat.com>
> Cc: Halil Pasic <pasic at linux.ibm.com>
> Cc: Stefan Hajnoczi <stefanha at redhat.com>
> Cc: qemu-s390x at nongnu.org
> Cc: virtio-fs at redhat.com
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  include/hw/virtio/vhost-user-fs.h |  1 +
>  hw/s390x/vhost-user-fs-ccw.c      |  2 ++
>  hw/virtio/vhost-user-fs-pci.c     |  2 ++
>  hw/virtio/vhost-user-fs.c         | 10 ++++++++++
>  4 files changed, 15 insertions(+)
> 

I agree that you should just drop the ccw hunk for now. The rest of the
patch looks good to me.




More information about the Virtio-fs mailing list