[Virtio-fs] [PATCH 1/1] fuse: send file mode updates using SETATTR

Miklos Szeredi miklos at szeredi.hu
Wed Mar 17 15:43:35 UTC 2021


On Tue, Mar 16, 2021 at 5:02 PM Vivek Goyal <vgoyal at redhat.com> wrote:
>
> If ACL changes, it is possible that file mode permission bits change. As of
> now fuse client relies on file server to make those changes. But it does
> not send enough information to server so that it can decide where SGID
> bit should be cleared or not. Server does not know if caller has CAP_FSETID
> or not. It also does not know what are caller's group memberships and if any
> of the groups match file owner group.

Right.  So what about performing the capability and group membership
check in the client and sending the result of this check to the
server?

Yes, need to extend fuse_setxattr_in.

There's still a race with uid and gid changing on the underlying
filesystem, so the attributes need to be refreshed, but I don't think
that's a big worry.

Thanks,
Miklos




More information about the Virtio-fs mailing list