[Virtio-fs] [PATCH v3 24/26] vhost-user-fs: Extend VhostUserFSSlaveMsg to pass additional info

Stefan Hajnoczi stefanha at redhat.com
Thu May 6 15:32:46 UTC 2021


On Wed, Apr 28, 2021 at 12:00:58PM +0100, Dr. David Alan Gilbert (git) wrote:
> @@ -144,6 +148,8 @@ typedef struct {
>  } VhostUserFSSlaveMsgEntry;
>  
>  typedef struct {
> +    /* Generic flags for the overall message */
> +    uint32_t flags;
>      /* Number of entries */
>      uint16_t count;
>      /* Spare */

Please introduce the uint32_t field as a reserved field in the earlier
patch that left a hole in the struct. Everything is okay once we get to
this patch but the earlier patches should have avoided the hole too
(they had the confusing uint16_t padding field which was not enough to
avoid the 64-bit alignment hole).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virtio-fs/attachments/20210506/5ba34138/attachment.sig>


More information about the Virtio-fs mailing list