[Virtio-fs] [PATCH 2/7] virtiofsd: Get rid of unreachable code in read
Dr. David Alan Gilbert
dgilbert at redhat.com
Tue May 18 12:01:24 UTC 2021
* Vivek Goyal (vgoyal at redhat.com) wrote:
> pvreadv() can return following.
>
> - error
> - 0 in case of EOF
> - short read
>
> We seem to handle all the cases already. We are retrying read in case
> of short read. So another check for short read seems like dead code.
> Get rid of it.
>
> Signed-off-by: Vivek Goyal <vgoyal at redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert at redhat.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 32914f7e95..5dcd08fccb 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -446,11 +446,6 @@ int virtio_send_data_iov(struct fuse_session *se, struct fuse_chan *ch,
> in_sg_left);
> break;
> }
> - if (ret != len) {
> - fuse_log(FUSE_LOG_DEBUG, "%s: ret!=len\n", __func__);
> - ret = EIO;
> - goto err;
> - }
> in_sg_left -= ret;
> len -= ret;
> } while (in_sg_left);
> --
> 2.25.4
>
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list