[Virtio-fs] [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

Peter Maydell peter.maydell at linaro.org
Wed Apr 20 16:10:51 UTC 2022


On Wed, 20 Apr 2022 at 16:04, Daniel P. Berrangé <berrange at redhat.com> wrote:
>
> On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
>
> Could use a commit message explaining why this is a good
> idea.
>
> I see it contains QEMU_COPYRIGHT macro, but it also then
> contains QEMU_HELP_BOTTOM which is about bug reporting
> not copyright.
>
> IMHO something like 'qemu-cli.h' could be a better match

"-cli" is both too broad and also inaccurate, because we use
these macros in the GUI UI frontends too. It's "macros defining
strings for use in version/usage/help dialogs and output".
Maybe qemu/help-texts.h ?

-- PMM



More information about the Virtio-fs mailing list