[Virtio-fs] [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

Michael S. Tsirkin mst at redhat.com
Mon Jul 10 20:15:36 UTC 2023


> +static const TypeInfo vud_info = {
> +    .name = TYPE_VHOST_USER_DEVICE,
> +    .parent = TYPE_VHOST_USER_BASE,
> +    .instance_size = sizeof(VHostUserBase),
> +    .class_init = vud_class_init,
> +    .class_size = sizeof(VHostUserBaseClass),

I wish you didn't tie the refactoring in with new functionality.
I applied but blocked creating these for now with:

Subject: [PATCH] vhost-user-device: block creating instances
Message-Id: <b10d1e585adf8a5348bd886333a8c55dcdef6048.1689020067.git.mst at redhat.com>

block this until we are ready to commit to this command line.

Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
 hw/virtio/vhost-user-device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/virtio/vhost-user-device.c b/hw/virtio/vhost-user-device.c
index 2b028cae08..ded97b6d70 100644
--- a/hw/virtio/vhost-user-device.c
+++ b/hw/virtio/vhost-user-device.c
@@ -369,6 +369,7 @@ static const TypeInfo vud_info = {
     .instance_size = sizeof(VHostUserBase),
     .class_init = vud_class_init,
     .class_size = sizeof(VHostUserBaseClass),
+    .abstract = true
 };

 static void vu_register_types(void)

-- 
MST



More information about the Virtio-fs mailing list