[Virtio-fs] [PATCH v2 01/10] qga: Remove platform GUID definitions

[Konstantin Kostiuk]

Hi Akihiko,

Thanks for ping.
I will merge this commit with other qga fixes.

Best Regards,
Konstantin Kostiuk.


On Thu, Sep 21, 2023 at 10:58 AM Akihiko Odaki <akihiko.odaki at daynix.com>
wrote:

> On 2022/11/17 18:45, Konstantin Kostiuk wrote:
> > Reviewed-by: Konstantin Kostiuk <kkostiuk at redhat.com
> > <mailto:kkostiuk at redhat.com>>
> >
> > Will merge this patch in QGA series
> >
> > On Thu, Nov 10, 2022 at 12:06 PM Akihiko Odaki <akihiko.odaki at daynix.com
> > <mailto:akihiko.odaki at daynix.com>> wrote:
> >
> >     GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
> >     defined by MinGW-w64. They are not only unnecessary, but can lead to
> >     duplicate definition errors at link time with some unknown condition.
> >
> >     Signed-off-by: Akihiko Odaki <akihiko.odaki at daynix.com
> >     <mailto:akihiko.odaki at daynix.com>>
> >     ---
> >       qga/commands-win32.c | 7 -------
> >       1 file changed, 7 deletions(-)
> >
> >     diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> >     index ec9f55b453..dde5d401bb 100644
> >     --- a/qga/commands-win32.c
> >     +++ b/qga/commands-win32.c
> >     @@ -506,13 +506,6 @@ static GuestDiskBusType
> >     find_bus_type(STORAGE_BUS_TYPE bus)
> >           return win2qemu[(int)bus];
> >       }
> >
> >     -DEFINE_GUID(GUID_DEVINTERFACE_DISK,
> >     -        0x53f56307L, 0xb6bf, 0x11d0, 0x94, 0xf2,
> >     -        0x00, 0xa0, 0xc9, 0x1e, 0xfb, 0x8b);
> >     -DEFINE_GUID(GUID_DEVINTERFACE_STORAGEPORT,
> >     -        0x2accfe60L, 0xc130, 0x11d2, 0xb0, 0x82,
> >     -        0x00, 0xa0, 0xc9, 0x1e, 0xfb, 0x8b);
> >     -
> >       static void get_pci_address_for_device(GuestPCIAddress *pci,
> >                                              HDEVINFO dev_info)
> >       {
> >     --
> >     2.38.1
> >
>
> Hi Konstantin,
>
> This patch seems missed since then. Can you merge it?
>
> Regards,
> Akihiko Odaki
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virtio-fs/attachments/20230921/6a890d2c/attachment-0001.htm>