[zanata-bugs] [Bug 1128549] New: If a cancelled version copy unlocks in background, maintainer unlocking throws exception

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1128549

            Bug ID: 1128549
           Summary: If a cancelled version copy unlocks in background,
                    maintainer unlocking throws exception
           Product: Zanata
           Version: 3.4
         Component: Component-UI
          Severity: medium
          Assignee: aeng at redhat.com
          Reporter: djansen at redhat.com
        QA Contact: zanata-qa at redhat.com
                CC: zanata-bugs at redhat.com



Created attachment 925611
  --> https://bugzilla.redhat.com/attachment.cgi?id=925611&action=edit
Stack trace of exception

Description of problem:
If a cancelled version copy is left for long enough, it may unlock in the
background. If the maintainer has not refreshed the page, the clicks "Make this
version writable", an OptimisticLockException exception will occur.

Version-Release number of selected component (if applicable):
3.5-snap, from https://github.com/zanata/zanata-server/pull/525

How reproducible:
Moderate, always

Steps to Reproduce:
Pre: project version with some reasonable number of documents exists
1. Sign in as a project admin, go to the project
2. Click the v next to a version and select Copy
3. enter a new version name, press create
4. While it is copying, press Stop, press Ok
5. Wait for the Stop button to disappear, and select the version
(if there is no lock icon, you'll need to do 2 - 5 again)
6. Press Settings to show the General Tab
- The "Make this version writable" button should be visible
7. Wait for some time, like a few minutes, then press the button

Actual results:
Transaction failed, another user changed the same data
javax.servlet.ServletException: javax.persistence.OptimisticLockException

Expected results:
It should just "do it" transparently, or issue a "Already ACTIVE" notification.

Additional info:
Stack attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1axIPDqU0R&a=cc_unsubscribe