[zanata/zanata] a8a4b1: Split EditorOptionsPanel to use MVP architecture
GitHub
noreply at github.com
Tue Feb 14 23:28:40 UTC 2012
Branch: refs/heads/master
Home: https://github.com/zanata/zanata
Commit: a8a4b161c420ed8c64fcb3bae49f19c6eac86a9e
https://github.com/zanata/zanata/commit/a8a4b161c420ed8c64fcb3bae49f19c6eac86a9e
Author: David Mason <dr.d.mason at gmail.com>
Date: 2012-02-13 (Mon, 13 Feb 2012)
Changed paths:
M server/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/OptionsPanelPresenter.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ValidationOptionsPresenter.java
R server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorOptionsPanel.java
R server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorOptionsPanel.ui.xml
M server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/OptionsPanelView.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/OptionsPanelView.ui.xml
M server/zanata-war/src/main/java/org/zanata/webtrans/client/view/TranslationView.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/view/ValidationOptionsView.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/view/ValidationOptionsView.ui.xml
Log Message:
-----------
Split EditorOptionsPanel to use MVP architecture
EditorOptionsPanel had both presenter and view logic in a single class, which makes unit testing very problematic.
As there was not much to the class, the logic and UI was moved into the OptionsPanel and divided between presenter and view as appropriate.
Commit: 095a95fbfb945b5db66b320df6216ce15cfb58a8
https://github.com/zanata/zanata/commit/095a95fbfb945b5db66b320df6216ce15cfb58a8
Author: David Mason <dr.d.mason at gmail.com>
Date: 2012-02-13 (Mon, 13 Feb 2012)
Changed paths:
M server/zanata-war/src/main/java/org/zanata/action/ProfileAction.java
M server/zanata-war/src/main/java/org/zanata/action/RegisterAction.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/editor/CheckKey.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/editor/CheckKeyImpl.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/EditorTextArea.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/InlineTargetCellEditor.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/TableEditorPresenter.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/editor/table/TableEditorTableDefinition.java
A server/zanata-war/src/main/java/org/zanata/webtrans/client/events/OpenEditorEvent.java
A server/zanata-war/src/main/java/org/zanata/webtrans/client/events/OpenEditorEventHandler.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TransMemoryPresenter.java
A server/zanata-war/src/main/java/org/zanata/webtrans/client/resources/EnumMessages.java
A server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/EnumListBox.java
A server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/EnumRenderer.java
A server/zanata-war/src/main/java/org/zanata/webtrans/client/ui/SearchTypeRenderer.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransMemoryView.java
M server/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransMemoryView.ui.xml
M server/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransMemoryHandler.java
M server/zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/GetTranslationMemory.java
M server/zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/GetTranslationMemoryResult.java
M server/zanata-war/src/main/webapp/WEB-INF/facelets/email/activation.xhtml
M server/zanata-war/src/test/java/org/zanata/webtrans/client/rpc/DummyGetTranslationMemoryCommand.java
Log Message:
-----------
Merge branch 'master' into rhbz789201
Compare: https://github.com/zanata/zanata/compare/ea7c85e...095a95f
More information about the zanata-commits
mailing list