[zanata/zanata] f1f80c: rhbz844820 - refactor gwt history handling

GitHub noreply at github.com
Fri Sep 14 01:13:18 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata
  Commit: f1f80c943f8b3a0f01533ad1c52ccaf8b6d7eb5f
      https://github.com/zanata/zanata/commit/f1f80c943f8b3a0f01533ad1c52ccaf8b6d7eb5f
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2012-09-13 (Thu, 13 Sep 2012)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/Application.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/editor/filter/TransFilterPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/events/DocumentSelectionEvent.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/gin/WebTransClientModule.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/gin/WebTransGinjector.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/AppPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/DocumentListPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/SearchResultsPresenter.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/service/HistoryEventHandlerService.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/service/NavigationController.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/ValidationMessagePanelView.ui.xml
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/AppDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/AppView.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/DocumentListView.java
    M zanata-war/src/test/java/org/zanata/model/TestFixture.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/AppPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/DocumentListPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/SearchResultsPresenterTest.java

  Log Message:
  -----------
  rhbz844820 - refactor gwt history handling

- eager load document list on GWT module load
- single handler listening to history change event so that it can do proper process in correct order
- refactored AppPresenter to use reverse MVP pattern so that it's easier to unit test
- rewrite AppPresenterTest after refactoring (it should NOT fail all tests if you just change small portion of code!!)


  Commit: eacdc6be7f12b3d9e10e5e776b69d1fda64dfaeb
      https://github.com/zanata/zanata/commit/eacdc6be7f12b3d9e10e5e776b69d1fda64dfaeb
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2012-09-13 (Thu, 13 Sep 2012)

  Changed paths:
    M zanata-war/src/main/resources/org/zanata/webtrans/public/codemirror.css

  Log Message:
  -----------
  rhbz844820 - change line height for code mirror editor


  Commit: 9ecf60e8e6c2813b60c1b76d290c9a56d294bf79
      https://github.com/zanata/zanata/commit/9ecf60e8e6c2813b60c1b76d290c9a56d294bf79
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2012-09-13 (Thu, 13 Sep 2012)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/ValidationMessagePanelView.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/ValidationMessagePanelView.ui.xml

  Log Message:
  -----------
  rhbz844820 - update validation panel to change style in header on error


Compare: https://github.com/zanata/zanata/compare/c12d1725a83f...9ecf60e8e6c2


More information about the zanata-commits mailing list