[zanata/zanata-server] 528577: Source File Upload Tests

[GitHub]

  Branch: refs/heads/document-upload-tests
  Home:   https://github.com/zanata/zanata-server
  Commit: 5285771beae41d41085a8747615862751ff62b18
      https://github.com/zanata/zanata-server/commit/5285771beae41d41085a8747615862751ff62b18
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-08-04 (Sun, 04 Aug 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/BasePage.java
    A functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    M functional-test/src/main/java/org/zanata/page/projects/ProjectVersionPage.java
    A functional-test/src/test/java/org/zanata/feature/document/UploadTest.java
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/java/org/zanata/util/ResetDatabaseRule.java
    M functional-test/src/test/resources/setup.properties
    A functional-test/testdata/cancelFileUpload.txt
    A functional-test/testdata/uploadedDocumentIsInFilesystem.txt
    M zanata-war/src/main/webapp/iteration/source_files.xhtml

  Log Message:
  -----------
  Source File Upload Tests

Add Uploaded source files testing. Handles success and error case.
Exception located in error cases, these tests are expect fail.
Added a 'Critical Error' check to BasePage and some hard defaults
for the document storage dir.
Added an action to delete the stored files on database reset.
Slight modification of ids in Source Documents pages.


  Commit: 1772519e9dca8f4d47b2beb7e1c9b1db27a5d408
      https://github.com/zanata/zanata-server/commit/1772519e9dca8f4d47b2beb7e1c9b1db27a5d408
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-08-04 (Sun, 04 Aug 2013)

  Changed paths:
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java

  Log Message:
  -----------
  Add too-large upload file test

Test for files that are too large to upload.


  Commit: 8e4f07441c271dccdb67d5572d1b826001d28f5b
      https://github.com/zanata/zanata-server/commit/8e4f07441c271dccdb67d5572d1b826001d28f5b
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-08-04 (Sun, 04 Aug 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/BasePage.java
    M functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/resources/setup.properties

  Log Message:
  -----------
  Fix up code review issues in Source Upload testing

Mostly blank lines and readbility.


  Commit: 70a9265ff9a26f008e1f791d26e3f1e9019d12ab
      https://github.com/zanata/zanata-server/commit/70a9265ff9a26f008e1f791d26e3f1e9019d12ab
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-08-04 (Sun, 04 Aug 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java

  Log Message:
  -----------
  Update UploadTest on review comments

Don't use globals for elements that may not exist.
Clear cached data between functions.
Wrong licence year.
Also added a test step for verifying the file is saved to the intended
location.


  Commit: 7ba5e3fe1a049f7370d69b93b3f873b929a8971e
      https://github.com/zanata/zanata-server/commit/7ba5e3fe1a049f7370d69b93b3f873b929a8971e
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-08-05 (Mon, 05 Aug 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    A functional-test/src/main/java/org/zanata/util/TestFileGenerator.java
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java
    M functional-test/src/test/resources/setup.properties
    M zanata-war/src/main/webapp/iteration/source_files.xhtml

  Log Message:
  -----------
  Use a generator instead of static files for testing

Rather than dumping a bunch of files in a dir, just use a generator
to create temp files.
Add a few more Upload tests to make use of this.


  Commit: fa07487570727fd4c08eb008166db30588d79fed
      https://github.com/zanata/zanata-server/commit/fa07487570727fd4c08eb008166db30588d79fed
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-08-05 (Mon, 05 Aug 2013)

  Changed paths:
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/java/org/zanata/util/ResetDatabaseRule.java

  Log Message:
  -----------
  Completely clear and rebuild the h2 database on reset

The sql backup procedure for the first run scenario writes the
sequence lines without the "if not exists" clause, so subsequent
runs can fail - especially after the user has executed some
tests manually.
Drop all items from the database and either restore a base from
the backup or a complete database with test data.


Compare: https://github.com/zanata/zanata-server/compare/6c63db798a4e...fa0748757072