[zanata/zanata-server] 41d1d3: Fix findbugs warnings in functional test framework

[GitHub]

  Branch: refs/heads/integration/master
  Home:   https://github.com/zanata/zanata-server
  Commit: 41d1d390c22d8d3938330d04efa9b87d6154f658
      https://github.com/zanata/zanata-server/commit/41d1d390c22d8d3938330d04efa9b87d6154f658
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-12-02 (Mon, 02 Dec 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/WebDriverFactory.java
    M functional-test/src/main/java/org/zanata/page/account/RegisterPage.java
    M functional-test/src/main/java/org/zanata/util/PropertiesHolder.java
    M functional-test/src/main/java/org/zanata/util/TestFileGenerator.java
    M functional-test/src/main/java/org/zanata/util/WebElementUtil.java
    M functional-test/src/main/java/org/zanata/workflow/LanguageWorkFlow.java
    M functional-test/src/main/java/org/zanata/workflow/LoginWorkFlow.java
    M functional-test/src/test/java/org/zanata/feature/security/SecurityFullTest.java

  Log Message:
  -----------
  Fix findbugs warnings in functional test framework

WebDriver is now volatile
Properties holder is static
Add null checks to nullable fields
Clean up and appropriately return workflow objects
Use stream writer to specify encoding type


  Commit: c0c50b975f16b8381c45408bf811c8e1adc4b176
      https://github.com/zanata/zanata-server/commit/c0c50b975f16b8381c45408bf811c8e1adc4b176
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-12-17 (Tue, 17 Dec 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/WebDriverFactory.java
    M functional-test/src/main/java/org/zanata/page/account/RegisterPage.java
    M functional-test/src/main/java/org/zanata/util/PropertiesHolder.java
    M functional-test/src/main/java/org/zanata/util/TestFileGenerator.java
    M functional-test/src/main/java/org/zanata/util/WebElementUtil.java
    M functional-test/src/main/java/org/zanata/workflow/LanguageWorkFlow.java
    M functional-test/src/main/java/org/zanata/workflow/LoginWorkFlow.java
    M functional-test/src/test/java/org/zanata/feature/security/SecurityFullTest.java

  Log Message:
  -----------
  Merge pull request #315 from zanata/fix-ft-findbugs

Fix findbugs warnings in functional test framework


Compare: https://github.com/zanata/zanata-server/compare/20297da89128...c0c50b975f16