[zanata/zanata-server] 906d47: rhbz978666 - add database table and liquibase chan...

Fri Jul 12 04:34:48 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-server
  Commit: 906d47d7d328a8bc50ba3ce517872479606017ee
      https://github.com/zanata/zanata-server/commit/906d47d7d328a8bc50ba3ce517872479606017ee
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTarget.java
    A zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java
    A zanata-war/src/main/resources/db/changelogs/db.changelog-3.1.xml
    M zanata-war/src/main/webapp-jboss/WEB-INF/classes/META-INF/persistence.xml
    M zanata-war/src/test/java/org/zanata/dao/TextFlowTargetDAOTest.java
    M zanata-war/src/test/resources/META-INF/persistence.xml
    M zanata-war/src/test/resources/arquillian/persistence.xml

  Log Message:
  -----------
  rhbz978666 - add database table and liquibase change log for review translation comment


  Commit: f07c6426c39e1c3fbfbb554e1918447229db8383
      https://github.com/zanata/zanata-server/commit/f07c6426c39e1c3fbfbb554e1918447229db8383
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTarget.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/TransUnitTransformer.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/model/TransUnit.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/model/UserComment.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowTargetDAOTest.java

  Log Message:
  -----------
  rhbz978666 - update TransUnit to indicate comment existance


  Commit: 643c7c233ab570d35d3638ee3bcf1d72fa3e7bf4
      https://github.com/zanata/zanata-server/commit/643c7c233ab570d35d3638ee3bcf1d72fa3e7bf4
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTarget.java
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java
    A zanata-war/src/main/java/org/zanata/dao/TextFlowTargetReviewCommentsDAO.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentDataProvider.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/resources/TableEditorMessages.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/resources/WebTransMessages.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorButtonsWidget.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorButtonsWidget.ui.xml
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentDisplay.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.ui.xml
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.java
    A zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    A zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetReviewCommentsHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/TransUnitTransformer.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/model/ReviewComment.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/model/ReviewCommentId.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/model/TransUnit.java
    R zanata-war/src/main/java/org/zanata/webtrans/shared/model/UserComment.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/AddReviewCommentAction.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/AddReviewCommentResult.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/GetReviewCommentsAction.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/GetReviewCommentsResult.java
    M zanata-war/src/main/resources/db/changelogs/db.changelog-3.1.xml
    M zanata-war/src/main/resources/db/db.changelog.xml
    M zanata-war/src/test/java/org/zanata/dao/TextFlowTargetDAOTest.java
    A zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java
    A zanata-war/src/test/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/TargetContentsPresenterTest.java
    A zanata-war/src/test/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandlerTest.java
    A zanata-war/src/test/java/org/zanata/webtrans/server/rpc/GetReviewCommentsHandlerTest.java
    M zanata-war/src/test/resources/org/zanata/test/model/ClearAllTables.dbunit.xml
    M zanata-war/src/test/resources/performance/GetTransUnitListTest.dbunit.xml

  Log Message:
  -----------
  rhbz978666 - UI and tests

- add review comment rpc
- get review comments rpc
- review comment gwt MVP
- change to TransUnit
- change to editor buttons display
- annotate a few areas that have technical debt (hibernate performance related)


  Commit: de9f9f2e6c66c29b705e18a902175456d658c86a
      https://github.com/zanata/zanata-server/commit/de9f9f2e6c66c29b705e18a902175456d658c86a
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/dao/TextFlowDAO.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandler.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowDAOTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/service/MockHandlerFactory.java

  Log Message:
  -----------
  Tech Debt: eager load text flow targets when we intended to access them


  Commit: 30a65f3adef2ec731f112d08610d5a3a2143eaf1
      https://github.com/zanata/zanata-server/commit/30a65f3adef2ec731f112d08610d5a3a2143eaf1
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/dao/TextFlowDAO.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandler.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowDAOTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/service/MockHandlerFactory.java

  Log Message:
  -----------
  rename methods after refactor


  Commit: 5bf3c8a9315d46afa7ba3938cf64808eea28ff0f
      https://github.com/zanata/zanata-server/commit/5bf3c8a9315d46afa7ba3938cf64808eea28ff0f
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/dao/TextFlowDAO.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandler.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowDAOTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/service/MockHandlerFactory.java

  Log Message:
  -----------
  revert optimization change

this is too big a refactoring and should do in its own pull request


  Commit: 65bd09cf2614484a32e92fbe0d4ab31fe643d7dd
      https://github.com/zanata/zanata-server/commit/65bd09cf2614484a32e92fbe0d4ab31fe643d7dd
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.ui.xml

  Log Message:
  -----------
  rhbz978666 - add comment indicator


  Commit: 3fbc6adde7ae59f2bdf354f5a3c62705df3f05c6
      https://github.com/zanata/zanata-server/commit/3fbc6adde7ae59f2bdf354f5a3c62705df3f05c6
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    A zanata-war/src/main/java/org/zanata/webtrans/client/events/ReviewCommentEvent.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/events/ReviewCommentEventHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorButtonsWidget.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.ui.xml
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenterTest.java

  Log Message:
  -----------
  rhbz978666 - add comment indicator


  Commit: 08d2414acfb5d8e5f752a7951f228236245234f6
      https://github.com/zanata/zanata-server/commit/08d2414acfb5d8e5f752a7951f228236245234f6
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/DocumentListPresenter.java

  Log Message:
  -----------
  minor clean up


  Commit: 1744a5abe854af58f236fad8da0630e1ce9c04af
      https://github.com/zanata/zanata-server/commit/1744a5abe854af58f236fad8da0630e1ce9c04af
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TransUnitsTablePresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/TransUnitTransformer.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/AddReviewCommentAction.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/TransUnitUpdated.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandlerTest.java

  Log Message:
  -----------
  rhbz978666 - comment change is broadcasted thru event service


  Commit: bad1cdb7699a92fd2b277040accde55d5470e524
      https://github.com/zanata/zanata-server/commit/bad1cdb7699a92fd2b277040accde55d5470e524
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/TransUnitTransformer.java

  Log Message:
  -----------
  minor - reformat comment


  Commit: a02e784e16db946bb0f6d2133c40827dd1b02bcc
      https://github.com/zanata/zanata-server/commit/a02e784e16db946bb0f6d2133c40827dd1b02bcc
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.ui.xml
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenterTest.java

  Log Message:
  -----------
  rhbz978666 - style comments made against old translation


  Commit: ec4db57ec73fa8d9274be1b992acdc6a73159a7f
      https://github.com/zanata/zanata-server/commit/ec4db57ec73fa8d9274be1b992acdc6a73159a7f
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java
    M zanata-war/src/main/java/org/zanata/dao/TextFlowTargetReviewCommentsDAO.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java
    M zanata-war/src/test/resources/org/zanata/test/model/TextFlowTestData.dbunit.xml

  Log Message:
  -----------
  rhbz978666 - minor query improvement


  Commit: 1a93c5a7873be09c8d1a8f4f6ded2f4cc7722e67
      https://github.com/zanata/zanata-server/commit/1a93c5a7873be09c8d1a8f4f6ded2f4cc7722e67
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.ui.xml

  Log Message:
  -----------
  minor ui change


  Commit: cf74cd1eec569e77164b0b398be02d4c4c93b34a
      https://github.com/zanata/zanata-server/commit/cf74cd1eec569e77164b0b398be02d4c4c93b34a
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java

  Log Message:
  -----------
  rhbz978666 - remove unused methods


  Commit: fa6a9e2fe66b7349f7128d4a59e830fcf5cafa3b
      https://github.com/zanata/zanata-server/commit/fa6a9e2fe66b7349f7128d4a59e830fcf5cafa3b
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java

  Log Message:
  -----------
  rhbz978666 - remove natural id annotation


  Commit: 3f56cb52d25c20d84bd8a71c309c44bcd9a39c5c
      https://github.com/zanata/zanata-server/commit/3f56cb52d25c20d84bd8a71c309c44bcd9a39c5c
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java

  Log Message:
  -----------
  rhbz978666 - use lombok for entity


  Commit: 7a846b5693e0cbda70137a0e189c777196012f55
      https://github.com/zanata/zanata-server/commit/7a846b5693e0cbda70137a0e189c777196012f55
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-war/src/main/webapp-jboss/WEB-INF/classes/META-INF/persistence.xml
    M zanata-war/src/test/java/org/zanata/dao/TextFlowDAOTest.java
    M zanata-war/src/test/resources/META-INF/persistence.xml
    M zanata-war/src/test/resources/arquillian/persistence.xml

  Log Message:
  -----------
  list classes in persistence.xml in alphabetical order


  Commit: 6ed1bc3bfaa59a03c8afc93a23ae8525afaced0d
      https://github.com/zanata/zanata-server/commit/6ed1bc3bfaa59a03c8afc93a23ae8525afaced0d
  Author: Alex Eng <aeng at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HTextFlowTarget.java
    A zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java
    A zanata-war/src/main/java/org/zanata/dao/TextFlowTargetReviewCommentsDAO.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/events/ReviewCommentEvent.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/events/ReviewCommentEventHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/DocumentListPresenter.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentDataProvider.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TransUnitsTablePresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/resources/TableEditorMessages.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/resources/WebTransMessages.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorButtonsWidget.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorButtonsWidget.ui.xml
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentDisplay.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.java
    A zanata-war/src/main/java/org/zanata/webtrans/client/view/ReviewCommentView.ui.xml
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.ui.xml
    A zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java
    A zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetReviewCommentsHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/GetTransUnitListHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/TransUnitTransformer.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/model/ReviewComment.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/model/ReviewCommentId.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/model/TransUnit.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/AddReviewCommentAction.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/AddReviewCommentResult.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/GetReviewCommentsAction.java
    A zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/GetReviewCommentsResult.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/TransUnitUpdated.java
    A zanata-war/src/main/resources/db/changelogs/db.changelog-3.1.xml
    M zanata-war/src/main/resources/db/db.changelog.xml
    M zanata-war/src/main/webapp-jboss/WEB-INF/classes/META-INF/persistence.xml
    M zanata-war/src/test/java/org/zanata/dao/TextFlowDAOTest.java
    M zanata-war/src/test/java/org/zanata/dao/TextFlowTargetDAOTest.java
    A zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java
    A zanata-war/src/test/java/org/zanata/webtrans/client/presenter/ReviewCommentPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/TargetContentsPresenterTest.java
    A zanata-war/src/test/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandlerTest.java
    A zanata-war/src/test/java/org/zanata/webtrans/server/rpc/GetReviewCommentsHandlerTest.java
    M zanata-war/src/test/resources/META-INF/persistence.xml
    M zanata-war/src/test/resources/arquillian/persistence.xml
    M zanata-war/src/test/resources/org/zanata/test/model/ClearAllTables.dbunit.xml
    M zanata-war/src/test/resources/org/zanata/test/model/TextFlowTestData.dbunit.xml
    M zanata-war/src/test/resources/performance/GetTransUnitListTest.dbunit.xml

  Log Message:
  -----------
  Merge pull request #19 from zanata/user-comments

Translation review comment


Compare: https://github.com/zanata/zanata-server/compare/b4192a107830...6ed1bc3bfaa5