[zanata/zanata-server] 6e9245: Extract methods for source and target document upl...

Mon Jul 22 00:13:08 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/zanata/zanata-server
  Commit: 6e92450179a66558218cce97fc32b2e455172c01
      https://github.com/zanata/zanata-server/commit/6e92450179a66558218cce97fc32b2e455172c01
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  Extract methods for source and target document upload.

    This is a preliminary step in moving this code into separate classes.

  Commit: 447bc0960c984188a110890d391a3a06b73bb3bb
      https://github.com/zanata/zanata-server/commit/447bc0960c984188a110890d391a3a06b73bb3bb
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.isNewDocument static (mikado method)

  Commit: 1c9ccda72b242b6baa25b47001cc1fd36a7aa019
      https://github.com/zanata/zanata-server/commit/1c9ccda72b242b6baa25b47001cc1fd36a7aa019
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.sourceUploadSuccessResponse static (mikado method)

  Commit: b4f1a974bf563a0ad6a21b772142b36a2a508334
      https://github.com/zanata/zanata-server/commit/b4f1a974bf563a0ad6a21b772142b36a2a508334
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.getInputStream static (mikado method)

  Commit: cc628afc49511a9c2eaf4e68fa258f8a2dac658f
      https://github.com/zanata/zanata-server/commit/cc628afc49511a9c2eaf4e68fa258f8a2dac658f
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.combineToTempFile static (mikado method)

  Commit: a1f58b7d8c2983b853976a081a6bc3b78f7bf21f
      https://github.com/zanata/zanata-server/commit/a1f58b7d8c2983b853976a081a6bc3b78f7bf21f
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.combineToTempFileAndDeleteUploadRecord static (mikado method)

  Commit: 44cebb1fab7e5ef541156e433f7ec007ccf4377d
      https://github.com/zanata/zanata-server/commit/44cebb1fab7e5ef541156e433f7ec007ccf4377d
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.persistTempFileFromUpload static (mikado method)

  Commit: 8c1533f23a786cda2d7b5c02f5c00cd24590f95b
      https://github.com/zanata/zanata-server/commit/8c1533f23a786cda2d7b5c02f5c00cd24590f95b
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.isDocumentUploadAllowed and .checkValidSourceUploadType static (mikado method)

  Commit: 8aa96f2eb3f6c31f2d188a1b4e9f9130debc3ec5
      https://github.com/zanata/zanata-server/commit/8aa96f2eb3f6c31f2d188a1b4e9f9130debc3ec5
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkSourceUploadAllowed static (mikado method)

  Commit: 739237b9e718b074613c4b031873e0c458bcb5fd
      https://github.com/zanata/zanata-server/commit/739237b9e718b074613c4b031873e0c458bcb5fd
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.retrieveUploadObject static (mikado method)

  Commit: f0ad299dc7e2ae35a8f2e8d6a598d2571bb753e8
      https://github.com/zanata/zanata-server/commit/f0ad299dc7e2ae35a8f2e8d6a598d2571bb753e8
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkUploadPreconditions static (mikado method)

  Commit: 8406c41a726b0692459bdc9f655f5ae2922f0331
      https://github.com/zanata/zanata-server/commit/8406c41a726b0692459bdc9f655f5ae2922f0331
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkSourceUploadPreconditions static (mikado method)

  Commit: de288bfa552dc5d62661d26a969d0cabcae8d78b
      https://github.com/zanata/zanata-server/commit/de288bfa552dc5d62661d26a969d0cabcae8d78b
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.saveUploadPart static (mikado method)

  Commit: b985a9222cb3540860cc1199c739addfd3e23789
      https://github.com/zanata/zanata-server/commit/b985a9222cb3540860cc1199c739addfd3e23789
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.parsePotFile static (mikado method)

  Commit: 486144e5772faa1cd77b0870140ae1859060dc63
      https://github.com/zanata/zanata-server/commit/486144e5772faa1cd77b0870140ae1859060dc63
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.processAdapterFile static (mikado method)

  Commit: 8d767c24f325ca0509c85208eac9c5a11a3f259c
      https://github.com/zanata/zanata-server/commit/8d767c24f325ca0509c85208eac9c5a11a3f259c
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.tryUploadSourceFile static (mikado method)

  Commit: 2be2f12986216e380572104b4d3c8d7ab4c9bc79
      https://github.com/zanata/zanata-server/commit/2be2f12986216e380572104b4d3c8d7ab4c9bc79
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    A zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  move all source upload methods from FileService to new DocumentUpload (mikado method)

  Commit: 01fd646c05d1a0ce1991ab0fe80dcbb1e00016d2
      https://github.com/zanata/zanata-server/commit/01fd646c05d1a0ce1991ab0fe80dcbb1e00016d2
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make tryUploadSourceFile an instance method (mikado method)

  Commit: 363ff91efd20f4ad6e687d119f09090ef6110599
      https://github.com/zanata/zanata-server/commit/363ff91efd20f4ad6e687d119f09090ef6110599
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make helper arguments for source upload into instance fields (mikado method)

  Commit: 4512ce78209fe6e41abc6ca226d3d0521d9351d4
      https://github.com/zanata/zanata-server/commit/4512ce78209fe6e41abc6ca226d3d0521d9351d4
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java

  Log Message:
  -----------
  make source upload helper methods private (mikado method)

  Commit: 425a3251d701dee9d047e539946e7c6bdca8b5df
      https://github.com/zanata/zanata-server/commit/425a3251d701dee9d047e539946e7c6bdca8b5df
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    A zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  move source upload and helper methods to subclass (mikado method)

  Commit: 48bf83b8cc2d6296fd58ef710d90ba7c50412a7d
      https://github.com/zanata/zanata-server/commit/48bf83b8cc2d6296fd58ef710d90ba7c50412a7d
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java

  Log Message:
  -----------
  use instance helpers in source upload methods (mikado method)

  Commit: b46e6e66bb6957f262ea2917da41763f2ca74a8f
      https://github.com/zanata/zanata-server/commit/b46e6e66bb6957f262ea2917da41763f2ca74a8f
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    M zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  use composite id object for all source upload methods (mikado method)

  Commit: cddc233baf8d441f5b30ec6a99417ad2da920e25
      https://github.com/zanata/zanata-server/commit/cddc233baf8d441f5b30ec6a99417ad2da920e25
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkDocumentExists static (mikado method)

  Commit: c2213fb90e2fe7209f7ff5a4cc9c1fd31ab1e8ba
      https://github.com/zanata/zanata-server/commit/c2213fb90e2fe7209f7ff5a4cc9c1fd31ab1e8ba
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkValidTranslationUploadType static (mikado method)

  Commit: fc4c7c71b1db4aa826e1b674fe4b7fccf8b07664
      https://github.com/zanata/zanata-server/commit/fc4c7c71b1db4aa826e1b674fe4b7fccf8b07664
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkTranslationUploadPrecondiditons static (mikado method)

  Commit: 6ca82d5e9c0a002a72adaac65270fa7cc300100b
      https://github.com/zanata/zanata-server/commit/6ca82d5e9c0a002a72adaac65270fa7cc300100b
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.findHLocale static (mikado method)

  Commit: 46a472ca684cacd3c030e5f7d8570b27c8830d0a
      https://github.com/zanata/zanata-server/commit/46a472ca684cacd3c030e5f7d8570b27c8830d0a
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.isTranslationUploadAllowed static (mikado method)

  Commit: 3e6f8997269e763f1dff0b4a464d1473a62b8e48
      https://github.com/zanata/zanata-server/commit/3e6f8997269e763f1dff0b4a464d1473a62b8e48
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.checkTranslationUploadAllowed static (mikado method)

  Commit: 860b096aa99c071a2627db850c6dccbaae8c599a
      https://github.com/zanata/zanata-server/commit/860b096aa99c071a2627db850c6dccbaae8c599a
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.newExtensions static (mikado method)

  Commit: 72e2055cb0aeba812fe7555aa30be5c9760dec41
      https://github.com/zanata/zanata-server/commit/72e2055cb0aeba812fe7555aa30be5c9760dec41
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.mergeTypeFromString static (mikado method)

  Commit: 789477c48d37adbe368dd84e82115a99bf1ad302
      https://github.com/zanata/zanata-server/commit/789477c48d37adbe368dd84e82115a99bf1ad302
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.transUploadResponse and helper static (mikado method)

  Commit: 2cac2c18f97e4953677f3384f3335eaf55afd96a
      https://github.com/zanata/zanata-server/commit/2cac2c18f97e4953677f3384f3335eaf55afd96a
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make FileService.tryUploadTranslationFile static (mikado method)

  Commit: 14772769034d3003f5d65ba1077e8a554cbc51a0
      https://github.com/zanata/zanata-server/commit/14772769034d3003f5d65ba1077e8a554cbc51a0
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    A zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  move all translation upload methods from FileService to new TranslationDocumentUpload (mikado method)

  Commit: 106cf414c872f4648b73d7c435603f1daeffdc56
      https://github.com/zanata/zanata-server/commit/106cf414c872f4648b73d7c435603f1daeffdc56
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make tryUploadTranslationFile an instance method (mikado method)

  Commit: ce90deb6a544b37bf1dfe372a274582b968891c0
      https://github.com/zanata/zanata-server/commit/ce90deb6a544b37bf1dfe372a274582b968891c0
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  make helper arguments to translation upload into instance fields (mikado method)

  Commit: 0d7bc9ebd7211a3fdd0d6e9eb963bd98086743dd
      https://github.com/zanata/zanata-server/commit/0d7bc9ebd7211a3fdd0d6e9eb963bd98086743dd
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java

  Log Message:
  -----------
  make translation upload helper methods private (mikado method)

  Commit: 01d0f7a037807a0096591b4333a6db48c83b0ec5
      https://github.com/zanata/zanata-server/commit/01d0f7a037807a0096591b4333a6db48c83b0ec5
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java

  Log Message:
  -----------
  protect shared upload helper methods (mikado method)

  Commit: b9fd4b42a936b506bacf743c9769bc645fa5801c
      https://github.com/zanata/zanata-server/commit/b9fd4b42a936b506bacf743c9769bc645fa5801c
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java

  Log Message:
  -----------
  use instance helpers for TranslationDocumentUpload methods (mikado method)

  Commit: 02762da1ba4344e2aaa95a6d46fcc420b67c8a16
      https://github.com/zanata/zanata-server/commit/02762da1ba4344e2aaa95a6d46fcc420b67c8a16
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    M zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java

  Log Message:
  -----------
  use instance helpers for DocumentUpload methods (mikado method)

  Commit: aed0cf5243cf44c582a2c6fbc5648606033eac38
      https://github.com/zanata/zanata-server/commit/aed0cf5243cf44c582a2c6fbc5648606033eac38
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  use composite id object for all translation upload methods (mikado method)

  Commit: d3f24c9e896e0346a133b329a0c5d924e35d57fd
      https://github.com/zanata/zanata-server/commit/d3f24c9e896e0346a133b329a0c5d924e35d57fd
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-16 (Tue, 16 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/GlobalDocumentId.java

  Log Message:
  -----------
  use consistent naming in GlobalDocumentId

  Commit: 9a821546ecdc874bc7e320109ab406b97e0169be
      https://github.com/zanata/zanata-server/commit/9a821546ecdc874bc7e320109ab406b97e0169be
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    R zanata-war/src/main/java/org/zanata/file/DocumentUpload.java
    A zanata-war/src/main/java/org/zanata/file/DocumentUploadUtil.java
    M zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java
    M zanata-war/src/test/java/org/zanata/rest/service/raw/FileRawRestITCase.java

  Log Message:
  -----------
  change document upload classes to services

  Commit: efcdf5c950319d414456168db4750deed3a2c6c7
      https://github.com/zanata/zanata-server/commit/efcdf5c950319d414456168db4750deed3a2c6c7
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java

  Log Message:
  -----------
  remove unnecessary warning suppression

  Commit: d20f7044d86d80241f4ee716130ce731dd5942ba
      https://github.com/zanata/zanata-server/commit/d20f7044d86d80241f4ee716130ce731dd5942ba
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    M zanata-war/src/test/java/org/zanata/rest/service/raw/FileRawRestITCase.java

  Log Message:
  -----------
  remove extra logging that was accidentally checked in

  Commit: 720a687f412b65bd60ba50d0d3c1754648959538
      https://github.com/zanata/zanata-server/commit/720a687f412b65bd60ba50d0d3c1754648959538
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    M zanata-war/src/test/java/org/zanata/rest/service/raw/FileRawRestITCase.java

  Log Message:
  -----------
  remove excessive comment

  Commit: 11c81ee15765607c829ccfb0afcc7fabb55bd1d1
      https://github.com/zanata/zanata-server/commit/11c81ee15765607c829ccfb0afcc7fabb55bd1d1
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-17 (Wed, 17 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUploadUtil.java
    M zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java

  Log Message:
  -----------
  refactor validity checking for file upload to increase readability

  Commit: f5a6a099f577d9abf88818a51eceb1b920c58ca2
      https://github.com/zanata/zanata-server/commit/f5a6a099f577d9abf88818a51eceb1b920c58ca2
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/SignInPage.java
    M functional-test/src/main/java/org/zanata/page/administration/ManageLanguageTeamMemberPage.java
    M functional-test/src/main/java/org/zanata/page/administration/ManageUserAccountPage.java
    A functional-test/src/test/java/org/zanata/feature/AggregateTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/BasicAcceptanceTest.java
    A functional-test/src/test/java/org/zanata/feature/BasicAcceptanceTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/ConcordionTest.java
    A functional-test/src/test/java/org/zanata/feature/ConcordionTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/DetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/DetailedTestSuite.java
    M functional-test/src/test/java/org/zanata/feature/account/InvalidEmailAddressTest.java
    R functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RegisterFullTest.java
    M functional-test/src/test/java/org/zanata/feature/account/RegisterTestSuite.java
    M functional-test/src/test/java/org/zanata/feature/account/UsernameValidationTest.java
    M functional-test/src/test/java/org/zanata/feature/account/ValidEmailAddressTest.java
    A functional-test/src/test/java/org/zanata/feature/administration/AdministrationTest.java
    M functional-test/src/test/java/org/zanata/feature/administration/AdministrationTestSuite.java
    R functional-test/src/test/java/org/zanata/feature/administration/ManageUsersDetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/administration/ManageUsersFullTest.java
    M functional-test/src/test/java/org/zanata/feature/administration/ManageUsersTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryDeleteTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryPushCSVTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryPushTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/InvalidGlossaryPushTest.java
    M functional-test/src/test/java/org/zanata/feature/security/LoginTest.java
    M functional-test/src/test/java/org/zanata/feature/security/SecurityTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/AddLanguageTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/CreateNewProjectTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/CreateVersionAndAddToProjectTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/DocumentListInWebTransTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/PushPodirPluralProjectTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/StartNewProjectTest.java
    M functional-test/src/test/java/org/zanata/feature/startNewProject/TranslatorJoinsLanguageTeamTest.java
    M functional-test/src/test/java/org/zanata/feature/versionGroup/VersionGroupBasicTest.java
    R functional-test/src/test/java/org/zanata/feature/versionGroup/VersionGroupDetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/versionGroup/VersionGroupFullTest.java
    A functional-test/src/test/java/org/zanata/feature/versionGroup/VersionGroupIDValidationTest.java
    M functional-test/src/test/java/org/zanata/feature/versionGroup/VersionGroupTest.java
    M functional-test/src/test/java/org/zanata/feature/versionGroup/VersionGroupTestSuite.java
    M functional-test/src/test/resources/concordion/org/zanata/feature/administration/ManageUsers.html
    M functional-test/src/test/resources/concordion/org/zanata/feature/zanata_with_data.sql
    M functional-test/src/test/resources/create_translator_user.sql
    M zanata-model/src/main/java/org/zanata/model/HLocale.java
    M zanata-model/src/main/java/org/zanata/model/HLocaleMember.java
    M zanata-war/eclipse/eclipse-code-formatter-profile.xml
    M zanata-war/pom.xml
    R zanata-war/src/etc/jboss-service-snippet.xml
    A zanata-war/src/main/java/org/zanata/action/LanguageJoinUpdateRoleAction.java
    M zanata-war/src/main/java/org/zanata/action/LanguageTeamAction.java
    M zanata-war/src/main/java/org/zanata/action/ProjectHome.java
    M zanata-war/src/main/java/org/zanata/action/ProjectIterationFilesAction.java
    M zanata-war/src/main/java/org/zanata/action/SendEmailAction.java
    M zanata-war/src/main/java/org/zanata/action/ViewAllStatusAction.java
    M zanata-war/src/main/java/org/zanata/dao/LocaleMemberDAO.java
    M zanata-war/src/main/java/org/zanata/dao/PersonDAO.java
    M zanata-war/src/main/java/org/zanata/security/SecurityFunctions.java
    M zanata-war/src/main/java/org/zanata/service/EmailService.java
    M zanata-war/src/main/java/org/zanata/service/LanguageTeamService.java
    M zanata-war/src/main/java/org/zanata/service/SecurityService.java
    M zanata-war/src/main/java/org/zanata/service/impl/LanguageTeamServiceImpl.java
    M zanata-war/src/main/java/org/zanata/service/impl/RegisterServiceImpl.java
    M zanata-war/src/main/java/org/zanata/util/EssentialDataCreator.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/SearchResultsPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TransMemoryPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TranslationPresenter.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/resources/WebTransMessages.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/service/TransUnitSaveService.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/Editor.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/ui/EditorButtonsWidget.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsDisplay.java
    M zanata-war/src/main/java/org/zanata/webtrans/client/view/TargetContentsView.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/ActivateWorkspaceHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/UpdateTransUnitHandler.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/model/UserWorkspaceContext.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/model/WorkspaceRestrictions.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/rpc/TransUnitUpdated.java
    M zanata-war/src/main/resources/db/changelogs/db.changelog-3.1.xml
    M zanata-war/src/main/resources/messages.properties
    M zanata-war/src/main/resources/messages_ja.properties
    M zanata-war/src/main/resources/messages_uk.properties
    M zanata-war/src/main/resources/messages_zh_TW_Hant.properties
    M zanata-war/src/main/resources/security.drl
    A zanata-war/src/main/webapp/WEB-INF/facelets/email/email_request_role_language.xhtml
    R zanata-war/src/main/webapp/WEB-INF/facelets/email/email_request_to_join.xhtml
    M zanata-war/src/main/webapp/WEB-INF/facelets/email/email_request_to_join_group.xhtml
    A zanata-war/src/main/webapp/WEB-INF/facelets/email/email_request_to_join_language.xhtml
    M zanata-war/src/main/webapp/WEB-INF/pages.xml
    M zanata-war/src/main/webapp/WEB-INF/urlrewrite.xml
    M zanata-war/src/main/webapp/iteration/files.xhtml
    M zanata-war/src/main/webapp/language/language.xhtml
    R zanata-war/src/main/webapp/language/request_to_join.xhtml
    A zanata-war/src/main/webapp/language/request_to_join_update_role.xhtml
    M zanata-war/src/main/webapp/project/project.xhtml
    M zanata-war/src/main/webapp/resources/css/zanata.css
    M zanata-war/src/test/java/org/zanata/dao/LocaleMemberDAOITCase.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/SearchResultsPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/TargetContentsPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/presenter/TransMemoryPresenterTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/client/service/TransUnitSaveServiceTest.java
    M zanata-war/src/test/java/org/zanata/webtrans/server/rpc/ActivateWorkspaceHandlerTest.java

  Log Message:
  -----------
  Merge branch 'master' into move-file-storage

  Commit: f56cfda33ac0733b3dc89760da76c73e1c830b76
      https://github.com/zanata/zanata-server/commit/f56cfda33ac0733b3dc89760da76c73e1c830b76
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUploadUtil.java

  Log Message:
  -----------
  use guava for null or empty strings

  Commit: e48634bb6a94dbb313aa745e3ea24b3920f638e0
      https://github.com/zanata/zanata-server/commit/e48634bb6a94dbb313aa745e3ea24b3920f638e0
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java

  Log Message:
  -----------
  use guava joiner for warning concatenation

  Commit: 9848834653b3c8b513711751716c67abed454598
      https://github.com/zanata/zanata-server/commit/9848834653b3c8b513711751716c67abed454598
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUploadUtil.java

  Log Message:
  -----------
  add TODOs for tasks in DocumentUploadUtil

  Commit: e49a38f3e2e147f1ccc0c6cd3151ff60f941b6c9
      https://github.com/zanata/zanata-server/commit/e49a38f3e2e147f1ccc0c6cd3151ff60f941b6c9
  Author: David Mason <dr.d.mason at gmail.com>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/file/DocumentUploadUtil.java
    M zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java

  Log Message:
  -----------
  add TODOs for classes that require unit tests

  Commit: 9993d5c7ad221a0cc672c0408d01016234ee0bdf
      https://github.com/zanata/zanata-server/commit/9993d5c7ad221a0cc672c0408d01016234ee0bdf
  Author: Patrick Huang <pahuang at redhat.com>
  Date:   2013-07-21 (Sun, 21 Jul 2013)

  Changed paths:
    A zanata-war/src/main/java/org/zanata/file/DocumentUploadUtil.java
    M zanata-war/src/main/java/org/zanata/file/GlobalDocumentId.java
    A zanata-war/src/main/java/org/zanata/file/SourceDocumentUpload.java
    A zanata-war/src/main/java/org/zanata/file/TranslationDocumentUpload.java
    M zanata-war/src/main/java/org/zanata/rest/service/FileService.java
    M zanata-war/src/test/java/org/zanata/rest/service/raw/FileRawRestITCase.java

  Log Message:
  -----------
  Merge pull request #55 from zanata/move-file-storage

Move code for file uploads to separate services.

Compare: https://github.com/zanata/zanata-server/compare/0e26920c3a31...9993d5c7ad22