[zanata/zanata-server] b81018: Prevent type coersion in components script.
GitHub
noreply at github.com
Wed Feb 18 05:09:38 UTC 2015
Branch: refs/heads/locale-aliases
Home: https://github.com/zanata/zanata-server
Commit: b81018847ebc03f4facba1909a6159a7f424a818
https://github.com/zanata/zanata-server/commit/b81018847ebc03f4facba1909a6159a7f424a818
Author: David Mason <drdmason at gmail.com>
Date: 2015-02-18 (Wed, 18 Feb 2015)
Changed paths:
M zanata-war/src/main/webapp/resources/script/components-script.js
Log Message:
-----------
Prevent type coersion in components script.
I found numerous uses of == comparison in components-script.js. Use
of == is error-prone as it can coerce types implicitly, leading to
unexpected results and unnoticed errors. Use of === is preferred for
this reason.
Commit: fdd36b75a65fdf82e7b45e70f18d2a536e761b28
https://github.com/zanata/zanata-server/commit/fdd36b75a65fdf82e7b45e70f18d2a536e761b28
Author: David Mason <drdmason at gmail.com>
Date: 2015-02-18 (Wed, 18 Feb 2015)
Changed paths:
M zanata-war/src/main/webapp/resources/script/components-script.js
Log Message:
-----------
Refactor components-script.js
The script had inconsistent use of semicolons, and some needless
repetition which is better removed.
Commit: c89199d47a6ba05e8d45fcc8292b90441b48c60e
https://github.com/zanata/zanata-server/commit/c89199d47a6ba05e8d45fcc8292b90441b48c60e
Author: David Mason <drdmason at gmail.com>
Date: 2015-02-18 (Wed, 18 Feb 2015)
Changed paths:
M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-languages.xhtml
M zanata-war/src/main/webapp/WEB-INF/layout/version/settings-tab-languages.xhtml
Log Message:
-----------
Use function from components-script in project and version language settings.
Compare: https://github.com/zanata/zanata-server/compare/e354027483be...c89199d47a6b
More information about the zanata-commits
mailing list