[zanata/zanata-server] b42cda: Filter active locale list as filter text changes.

GitHub noreply at github.com
Wed Jan 28 07:06:09 UTC 2015


  Branch: refs/heads/locale-aliases-select-checkboxes
  Home:   https://github.com/zanata/zanata-server
  Commit: b42cda6400b477f801e5d7bd29db013f4975df45
      https://github.com/zanata/zanata-server/commit/b42cda6400b477f801e5d7bd29db013f4975df45
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/action/ProjectHome.java
    M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml

  Log Message:
  -----------
  Filter active locale list as filter text changes.

    This performs a 'live' filter which shows and hides locales in the active list
    as the user types in the filter textbox.
    A placeholder message is shown when no items match the filter text.

    The selection state of each language is maintained when it is hidden. This is
    done on purpose since we considered it better for usability if a language is
    not de-selected unless the user performs an operation that visibly de-selects
    it. This was a little complicated since hidden rows should not be treated as
    selected when they are submitted, and I was not able to clear their selection
    state on submit. Instead, when a selected row is hidden, I clear the check
    state and add the data 'checked-when-visible=true' to the checkbox element. When
    a row is shown and the data is present, the check state is restored and the
    data is cleared.


  Commit: 68a13237cde590e65f55237cbf526b73bbaa55f0
      https://github.com/zanata/zanata-server/commit/68a13237cde590e65f55237cbf526b73bbaa55f0
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml

  Log Message:
  -----------
  Move checkbox reload script to end of reloaded panel.

This is necessary to ensure that all checkboxes have their facades
properly refreshed. In the previous position it was missing the
select-all checkboxes. This is probably also because the selector
was too specific, specifying only the language items rather than the
whole area.


  Commit: f3e2c7e75fac47e17a23d255f679ac810195e1c6
      https://github.com/zanata/zanata-server/commit/f3e2c7e75fac47e17a23d255f679ac810195e1c6
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml

  Log Message:
  -----------
  Move language list UI refresh script to end of language list panel.

The script is placed at the end of the panel so that it will run after the DOM
for the panel has been built, so all elements will definitely be available.

The target element for the checkbox refresh is also changed to be the entire
panel, since it was missing the select-all checkboxes when being run on only
the two lists separately.


Compare: https://github.com/zanata/zanata-server/compare/66fcdca7f6d2...f3e2c7e75fac


More information about the zanata-commits mailing list