[zanata/zanata-server] 53ba4a: Filter active locale list as filter text changes.

GitHub noreply at github.com
Thu Jan 29 04:49:25 UTC 2015


  Branch: refs/heads/locale-aliases-select-checkboxes
  Home:   https://github.com/zanata/zanata-server
  Commit: 53ba4a7c70e8e86e2e66cd676968a68f3cc0a6e7
      https://github.com/zanata/zanata-server/commit/53ba4a7c70e8e86e2e66cd676968a68f3cc0a6e7
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-01-29 (Thu, 29 Jan 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/action/ProjectHome.java
    M zanata-war/src/main/resources/messages.properties
    M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml

  Log Message:
  -----------
  Filter active locale list as filter text changes.

    This performs a 'live' filter which shows and hides locales in the active list
    as the user types in the filter textbox.
    A placeholder message is shown when no items match the filter text.

    The selection state of each language is maintained when it is hidden. This is
    done on purpose since we considered it better for usability if a language is
    not de-selected unless the user performs an operation that visibly de-selects
    it. This was a little complicated since hidden rows should not be treated as
    selected when they are submitted, and I was not able to clear their selection
    state on submit. Instead, when a selected row is hidden, I clear the check
    state and add the data 'checked-when-visible=true' to the checkbox element. When
    a row is shown and the data is present, the check state is restored and the
    data is cleared.


  Commit: f72b685bcd5095a090a9ed1dedfc624e67600e2e
      https://github.com/zanata/zanata-server/commit/f72b685bcd5095a090a9ed1dedfc624e67600e2e
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-01-29 (Thu, 29 Jan 2015)

  Changed paths:
    M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml

  Log Message:
  -----------
  Move checkbox reload script to end of reloaded panel.

This is necessary to ensure that all checkboxes have their facades
properly refreshed. In the previous position it was missing the
select-all checkboxes. This is probably also because the selector
was too specific, specifying only the language items rather than the
whole area.


  Commit: b68d71277573000d6520de2219dffcd9c7469b43
      https://github.com/zanata/zanata-server/commit/b68d71277573000d6520de2219dffcd9c7469b43
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-01-29 (Thu, 29 Jan 2015)

  Changed paths:
    M zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml

  Log Message:
  -----------
  Move language list UI refresh script to end of language list panel.

The script is placed at the end of the panel so that it will run after the DOM
for the panel has been built, so all elements will definitely be available.

The target element for the checkbox refresh is also changed to be the entire
panel, since it was missing the select-all checkboxes when being run on only
the two lists separately.


Compare: https://github.com/zanata/zanata-server/compare/f3e2c7e75fac...b68d71277573


More information about the zanata-commits mailing list