[zanata/zanata-server] ffb74f: Make method non-final (not allowed for CDI beans)

[GitHub]

  Branch: refs/heads/remove-final-method
  Home:   https://github.com/zanata/zanata-server
  Commit: ffb74fc187629ac155b117540c6977f1e81a4e9a
      https://github.com/zanata/zanata-server/commit/ffb74fc187629ac155b117540c6977f1e81a4e9a
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2015-07-07 (Tue, 07 Jul 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AbstractActionHandler.java

  Log Message:
  -----------
  Make method non-final (not allowed for CDI beans)


  Commit: 25636609e354f7e54704af58aac2844372706982
      https://github.com/zanata/zanata-server/commit/25636609e354f7e54704af58aac2844372706982
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2015-07-07 (Tue, 07 Jul 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/WebAssetsConfiguration.java
    M zanata-war/src/main/java/org/zanata/email/EmailBuilder.java
    M zanata-war/src/main/java/org/zanata/i18n/Messages.java
    M zanata-war/src/main/java/org/zanata/rest/service/ResourceUtils.java
    M zanata-war/src/main/java/org/zanata/rest/service/VersionService.java
    M zanata-war/src/main/java/org/zanata/service/impl/TranslationStateCacheImpl.java
    M zanata-war/src/main/java/org/zanata/service/impl/VersionStateCacheImpl.java
    M zanata-war/src/main/java/org/zanata/util/CommonMarkRenderer.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/SeamDispatch.java
    M zanata-war/src/main/java/org/zanata/webtrans/server/TranslationWorkspaceManagerImpl.java
    M zanata-war/src/test/java/org/zanata/email/EmailStrategyTest.java
    M zanata-war/src/test/java/org/zanata/notification/LanguageTeamPermissionChangeJmsMessagePayloadHandlerTest.java
    M zanata-war/src/test/java/org/zanata/service/impl/TranslationStateCacheImplTest.java

  Log Message:
  -----------
  Move constructor logic to @Create methods

In both Seam and CDI, the bean's constructor will be invoked twice:
once for the proxy object, and once for the actual instance, so any
logic should be in @Create/@PostConstruct methods, not the constructor.

In Seam, @javax.annotation.PostConstruct methods appear to cause Seam to
treat the bean as an EJB, which means some injections don't happen before
the @PostConstruct method (or at all, possibly).  (These methods will be
migrated to @PostConstruct for CDI.)


Compare: https://github.com/zanata/zanata-server/compare/a415f5990e0e...25636609e354