[zanata/zanata-server] 8160d0: feat(project-translation-teams): use HProject_Memb...

GitHub noreply at github.com
Mon Jul 13 23:29:05 UTC 2015


  Branch: refs/heads/add-project-roles-rhbz1223588
  Home:   https://github.com/zanata/zanata-server
  Commit: 8160d0bdf6a199d6a777f98b1a60523bc97c767f
      https://github.com/zanata/zanata-server/commit/8160d0bdf6a199d6a777f98b1a60523bc97c767f
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-07-14 (Tue, 14 Jul 2015)

  Changed paths:
    M zanata-model/src/main/java/org/zanata/model/HPerson.java
    M zanata-model/src/main/java/org/zanata/model/HProject.java
    A zanata-model/src/main/java/org/zanata/model/HProjectMember.java
    M zanata-war/src/main/java/org/zanata/action/ProjectHome.java
    M zanata-war/src/main/java/org/zanata/dao/ProjectDAO.java
    A zanata-war/src/main/java/org/zanata/dao/ProjectMemberDAO.java
    M zanata-war/src/main/java/org/zanata/rest/service/ProjectService.java
    M zanata-war/src/main/java/org/zanata/security/SecurityFunctions.java
    M zanata-war/src/main/java/org/zanata/service/impl/RegisterServiceImpl.java
    M zanata-war/src/main/resources/db/changelogs/db.changelog-3.8.xml
    M zanata-war/src/main/webapp-jboss/WEB-INF/classes/META-INF/persistence.xml
    M zanata-war/src/test/resources/META-INF/persistence.xml
    M zanata-war/src/test/resources/arquillian/persistence.xml

  Log Message:
  -----------
  feat(project-translation-teams): use HProject_Member to record maintainer status

Removes the old HProject_Maintainers table, since HProject_Member now records maintainer status.
Permission checks are changed to use HQL queries in the new ProjectMemberDAO both because:
 - it is more efficient: executes a single query rather than loading an entire collection
 - it avoids issues trying to filter a lazy collection that has already been detached


  Commit: 0ad4f839dd3604fa06489c0603f90a8d37be9ce6
      https://github.com/zanata/zanata-server/commit/0ad4f839dd3604fa06489c0603f90a8d37be9ce6
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-07-14 (Tue, 14 Jul 2015)

  Changed paths:
    M zanata-war/src/main/webapp/project/project.xhtml

  Log Message:
  -----------
  refactor(jsf): use absolute path for includes and templates

This is more maintainable since the paths will now stay valid even if the
file that uses the templates and includes moves to a different location.
This frees us up to organize our JSF templates with less chance of breakages.


  Commit: ab25c91e29f847b7983e6890b445e462eadd1e41
      https://github.com/zanata/zanata-server/commit/ab25c91e29f847b7983e6890b445e462eadd1e41
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-07-14 (Tue, 14 Jul 2015)

  Changed paths:
    M zanata-war/src/main/webapp/project/project.xhtml

  Log Message:
  -----------
  refactor(jsf): match doctype to root element in project.xhtml

A warning was generated by the IDE because the root element and doctype did not
match. We have a mix of doctype "html" and "composition" for <ui:composition>
templates and they seem to work with either, so it seems sensible to make them
consistent by changing them all to the one that does not generate a warning.


Compare: https://github.com/zanata/zanata-server/compare/2b48f6d5bdf5...ab25c91e29f8


More information about the zanata-commits mailing list