[zanata/zanata-server] df5ca9: Workaround TM result coalescing bug.

[GitHub]

  Branch: refs/heads/new-tm-endpoints-rhbz1209669
  Home:   https://github.com/zanata/zanata-server
  Commit: df5ca9077c6dbccc2ea5d9c28a7d3882d83bebd9
      https://github.com/zanata/zanata-server/commit/df5ca9077c6dbccc2ea5d9c28a7d3882d83bebd9
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-17 (Sun, 17 May 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/service/impl/TranslationMemoryServiceImpl.java
    M zanata-war/src/main/java/org/zanata/webtrans/shared/model/TransMemoryResultItem.java

  Log Message:
  -----------
  Workaround TM result coalescing bug.

Refactors the match processing code to make it clearer what type of
match is being added to a result item, and makes a few small changes
to minimize the incorrect behaviour:

 - No longer adds imported TM item id to the list that is used to look
   up text flows.
  A more complete fix is to wrap the Long id in a type so that
       all the ids are present and can be used sensibly. This just
       makes the list appropriate for the code that uses it right
       now, to delay spending the development time for the full fix.

 - Upgrades match type when a match has a higher match type, where
   ApprovedInternal > TranslatedInternal > Imported.
  Imported is treated as lowest just because the editor suppresses
       details display for Imported. Treating the others as higher will
       allow users to see text flow details for the other types.
  The full fix for this would be to inculde a summary of all the
       match types in the DTO, so the editor can display whatever
       makes sense.


  Commit: 30b8dac0e69d4e4a66a6763907877ad447893598
      https://github.com/zanata/zanata-server/commit/30b8dac0e69d4e4a66a6763907877ad447893598
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-17 (Sun, 17 May 2015)

  Changed paths:
    A zanata-war/src/main/java/org/zanata/rest/editor/dto/suggestion/JsonDateSerializer.java
    A zanata-war/src/main/java/org/zanata/rest/editor/dto/suggestion/Suggestion.java
    A zanata-war/src/main/java/org/zanata/rest/editor/dto/suggestion/SuggestionDetail.java
    A zanata-war/src/main/java/org/zanata/rest/editor/dto/suggestion/TextFlowSuggestionDetail.java
    A zanata-war/src/main/java/org/zanata/rest/editor/dto/suggestion/TransMemoryUnitSuggestionDetail.java

  Log Message:
  -----------
  Add DTOs for suggestions and suggestion detail.

These DTO classes are only configured to serialize to JSON, and I have
not considered deserialization since this is query data and not expected
to be uploaded to the server.


  Commit: f073249755f6d4f68af607e5e4dc598e885029cc
      https://github.com/zanata/zanata-server/commit/f073249755f6d4f68af607e5e4dc598e885029cc
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-17 (Sun, 17 May 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/service/TranslationMemoryService.java
    M zanata-war/src/main/java/org/zanata/service/impl/TranslationMemoryServiceImpl.java

  Log Message:
  -----------
  Add method to get suggestions from TM service.

I have avoided changing the existing code paths for TM search for now
since it is a performance-critical component for translation copy. We
should combine the code paths in a separate operation as long as it
does not impact on performance.


  Commit: 013176ecb1d195e67b629bcacf991b98d654733a
      https://github.com/zanata/zanata-server/commit/013176ecb1d195e67b629bcacf991b98d654733a
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-17 (Sun, 17 May 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/editor/MediaTypes.java
    A zanata-war/src/main/java/org/zanata/rest/editor/service/SuggestionsService.java
    A zanata-war/src/main/java/org/zanata/rest/editor/service/resource/SuggestionsResource.java

  Log Message:
  -----------
  Add REST endpoint for suggestions for editor.


Compare: https://github.com/zanata/zanata-server/compare/32a78fed0aaa...013176ecb1d1