[zanata/zanata-server] 4f224e: Keep format strings in the same scope as String.fo...

[GitHub]

  Branch: refs/heads/new-tm-endpoints-rhbz1209669
  Home:   https://github.com/zanata/zanata-server
  Commit: 4f224e6b34f02ebdd952dd8beaecb91bc40f9cf0
      https://github.com/zanata/zanata-server/commit/4f224e6b34f02ebdd952dd8beaecb91bc40f9cf0
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/editor/service/SuggestionsService.java

  Log Message:
  -----------
  Keep format strings in the same scope as String.format()

Format strings were being passed to a function, which seems confusing
and so more error-prone. Changed to passing an already-formatted string
so that the format strings can be inlined in the call to String.format()
so that it is obvious that they are format strings and what the
placeholders represent.


  Commit: 2ab4f61676636280116a4a1e45e2cbbbc4326015
      https://github.com/zanata/zanata-server/commit/2ab4f61676636280116a4a1e45e2cbbbc4326015
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/editor/service/SuggestionsService.java

  Log Message:
  -----------
  Make search type lookup case-insensitive.

The try block could be removed because iterating enum values will not
give nulls, and equalsIgnoreCase will behave sensibly with an entered
null value.


  Commit: a2f445663cb12d594884d941b001cb6de4d95210
      https://github.com/zanata/zanata-server/commit/a2f445663cb12d594884d941b001cb6de4d95210
  Author: David Mason <drdmason at gmail.com>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/rest/editor/service/SuggestionsService.java
    M zanata-war/src/main/java/org/zanata/service/impl/LocaleServiceImpl.java

  Log Message:
  -----------
  Prevent undeclared IllegalArgumentException when looking up locales.


Compare: https://github.com/zanata/zanata-server/compare/013176ecb1d1...a2f445663cb1