[zanata/zanata-server] bc8a15: refactor(editor): enable react/jsx-indent linting ...

GitHub noreply at github.com
Thu Jul 14 06:16:25 UTC 2016


  Branch: refs/heads/frontend-dependency-versions-ZNTA1220
  Home:   https://github.com/zanata/zanata-server
  Commit: bc8a15b43760b28eb7fe5762beae25fde106fffb
      https://github.com/zanata/zanata-server/commit/bc8a15b43760b28eb7fe5762beae25fde106fffb
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M zanata-editor/src/.eslintrc
    M zanata-editor/src/app/components/DashboardLink.js
    M zanata-editor/src/app/components/LogoLoader/index.js
    M zanata-editor/src/app/components/Pager.js
    M zanata-editor/src/app/components/ProgressBar/index.js
    M zanata-editor/src/app/components/SuggestionContents.js
    M zanata-editor/src/app/components/TransUnitSourceHeader.js
    M zanata-editor/src/app/components/TransUnitSourcePanel.js
    M zanata-editor/src/app/components/TransUnitStatus.js
    M zanata-editor/src/app/components/TransUnitTranslationFooter.js
    M zanata-editor/src/app/components/TransUnitTranslationPanel.js
    M zanata-editor/src/app/containers/NeedSlugMessage.js
    M zanata-editor/src/app/containers/SuggestionsHeader.js

  Log Message:
  -----------
  refactor(editor): enable react/jsx-indent linting rule for zanata-editor

This rule leads to some odd indentation around ternary operators and
logic operators, but there is an active bug for it so it should be ok
to leave the rule on and wait for a fix.
See https://github.com/yannickcr/eslint-plugin-react/issues/540


  Commit: 062a9f7b751537e63c99ddd8cd9d88c3ca1ff3b0
      https://github.com/zanata/zanata-server/commit/062a9f7b751537e63c99ddd8cd9d88c3ca1ff3b0
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M zanata-editor/src/.eslintrc
    M zanata-editor/src/app/components/DashboardLink.js
    M zanata-editor/src/app/components/DocsDropdown.js
    M zanata-editor/src/app/components/Dropdown/index.js
    M zanata-editor/src/app/components/FilterToggle/index.js
    M zanata-editor/src/app/components/Icon/index.js
    M zanata-editor/src/app/components/LanguagesDropdown.js
    M zanata-editor/src/app/components/Pager.js
    M zanata-editor/src/app/components/ProjectVersionLink.js
    M zanata-editor/src/app/components/SplitDropdown/index.js
    M zanata-editor/src/app/components/SuggestionContents.js
    M zanata-editor/src/app/components/SuggestionList.js
    M zanata-editor/src/app/components/SuggestionSearchInput/index.js
    M zanata-editor/src/app/components/SuggestionUpdateMessage.js
    M zanata-editor/src/app/components/ToggleSwitch/index.js
    M zanata-editor/src/app/components/TransUnit/index.js
    M zanata-editor/src/app/components/TransUnitTranslationFooter.js
    M zanata-editor/src/app/containers/KeyShortcutDispatcher.js
    M zanata-editor/src/app/containers/MainContent.js
    M zanata-editor/src/app/containers/NavHeader.js

  Log Message:
  -----------
  refactor(editor): enable react/jsx-indent-props linting rule for zanata-editor

This rule has similar indenting problems to react/jsx-indent, so I will treat
it the same way: enable the rule and wait for a bug fix in the linter before
fixing up the indentation.


  Commit: bbe6cc5ea56ba3b30643a4dce03e8bd66c982fb2
      https://github.com/zanata/zanata-server/commit/bbe6cc5ea56ba3b30643a4dce03e8bd66c982fb2
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M zanata-editor/src/.eslintrc
    M zanata-editor/src/app/components/DashboardLink.js
    M zanata-editor/src/app/components/DocsDropdown.js
    M zanata-editor/src/app/components/FilterToggle/index.js
    M zanata-editor/src/app/components/Icon/index.js
    M zanata-editor/src/app/components/IconButton.js
    M zanata-editor/src/app/components/IconButtonToggle.js
    M zanata-editor/src/app/components/LanguagesDropdown.js
    M zanata-editor/src/app/components/NoSuggestionsPanel.js
    M zanata-editor/src/app/components/Pager.js
    M zanata-editor/src/app/components/ProgressBar/index.js
    M zanata-editor/src/app/components/Suggestion.js
    M zanata-editor/src/app/components/SuggestionContents.js
    M zanata-editor/src/app/components/SuggestionList.js
    M zanata-editor/src/app/components/SuggestionSearchInput/index.js
    M zanata-editor/src/app/components/SuggestionSourceDetails.js
    M zanata-editor/src/app/components/SuggestionSources.js
    M zanata-editor/src/app/components/SuggestionTranslationDetails.js
    M zanata-editor/src/app/components/SuggestionTranslations.js
    M zanata-editor/src/app/components/SuggestionUpdateMessage.js
    M zanata-editor/src/app/components/ToggleSwitch/index.js
    M zanata-editor/src/app/components/TransUnit/index.js
    M zanata-editor/src/app/components/TransUnitFilter.js
    M zanata-editor/src/app/components/TransUnitSourceHeader.js
    M zanata-editor/src/app/components/TransUnitSourcePanel.js
    M zanata-editor/src/app/components/TransUnitStatus.js
    M zanata-editor/src/app/components/TransUnitTranslationFooter.js
    M zanata-editor/src/app/components/TransUnitTranslationHeader.js
    M zanata-editor/src/app/components/TransUnitTranslationPanel.js
    M zanata-editor/src/app/components/TranslatingIndicator.js
    M zanata-editor/src/app/containers/ControlsHeader.js
    M zanata-editor/src/app/containers/EditorHeader/index.js
    M zanata-editor/src/app/containers/KeyShortcutCheatSheet/index.js
    M zanata-editor/src/app/containers/MainContent.js
    M zanata-editor/src/app/containers/NavHeader.js
    M zanata-editor/src/app/containers/Root/index.js
    M zanata-editor/src/app/containers/SuggestionsBody.js
    M zanata-editor/src/app/containers/SuggestionsHeader.js
    M zanata-editor/src/app/containers/SuggestionsPanel.js
    M zanata-editor/src/app/containers/ZanataLogoLoader.js
    M zanata-editor/src/app/index.js

  Log Message:
  -----------
  refactor(editor): enable style rule react/jsx-space-before-closing

Includes many simple code fixes to pass the newly activated linting
rule.


  Commit: 7d2788973f9c743f54376e6777c897413da9dfb1
      https://github.com/zanata/zanata-server/commit/7d2788973f9c743f54376e6777c897413da9dfb1
  Author: David Mason <drdmason at gmail.com>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M zanata-editor/src/.eslintrc
    M zanata-editor/src/app/components/Dropdown/index.js
    M zanata-editor/src/app/components/SplitDropdown/index.js

  Log Message:
  -----------
  refactor(editor): enable linting rule react/jsx-boolean-value


Compare: https://github.com/zanata/zanata-server/compare/1b1f0f13e10d...7d2788973f9c


More information about the zanata-commits mailing list